[WFCORE-499] : System properties are broken in domain mode.

[ehsavoie]

Allowing the boot-time attribute for managed servers.

Jira: https://issues.jboss.org/browse/WFCORE-499

[wildfly-ci]

Core - Full Integration Build 398 is now running using a merge of 8d981b4

[wildfly-ci]

Windows Build 820 is now running using a merge of 8d981b4

[wildfly-ci]

Linux Build 1121 is now running using a merge of 8d981b4

[wildfly-ci]

Windows Build 820 outcome was SUCCESS using a merge of 8d981b4
Summary: Tests passed: 2981, ignored: 95 Build time: 0:17:57

[wildfly-ci]

Linux Build 1121 outcome was SUCCESS using a merge of 8d981b4
Summary: Tests passed: 2981, ignored: 95 Build time: 0:18:38

[wildfly-ci]

Core - Full Integration Build 398 outcome was SUCCESS using a merge of 8d981b4
Summary: Tests passed: 2856, ignored: 378 Build time: 0:51:24

[bstansberry]

The "boot-time" attribute doesn't belong on a server. It's an instruction to the HC to apply the property as part of the command used to launch the java.lang.Process; i.e. used in ManagedServerBootCmdFactory. So any system-property resource with that set to 'true' should not become part of the server's configuration model.

[bstansberry]

My guess is this was the problem:

#387

and this is the fix:

bstansberry@0065d42

[bstansberry]

That commits fixes the https://issues.jboss.org/browse/WFLY-4299 problem, which looks to be just a specific example of WFCORE-499.

[bstansberry]

I think for a test like this it would be good to use the core-service=platform-mbean stuff to validate the actual system property in the server VM. org.jboss.as.test.deployment.trivial.ServiceActivatorDeploymentUtil has some utility code related to reading system properties that way.

[ehsavoie]

Fixing missing code and covering with a test.

[wildfly-ci]

Core - Full Integration Build 421 is now running using a merge of 0a642e6

[wildfly-ci]

Linux Build 1147 is now running using a merge of 0a642e6

[wildfly-ci]

Windows Build 843 is now running using a merge of 0a642e6

[wildfly-ci]

Windows Build 843 outcome was SUCCESS using a merge of 0a642e6
Summary: Tests passed: 2987, ignored: 95 Build time: 0:18:17

[wildfly-ci]

Linux Build 1147 outcome was SUCCESS using a merge of 0a642e6
Summary: Tests passed: 2987, ignored: 95 Build time: 0:18:45

[wildfly-ci]

Core - Full Integration Build 421 outcome was FAILURE using a merge of 0a642e6
Summary: Tests failed: 1 (1 new), passed: 2855, ignored: 378 Build time: 0:48:40

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.clustering.cluster.ejb.remote.RemoteFailoverTestCase(SYNC-tcp).testStatelessFailover: java.lang.AssertionError: 0 invocations were routed to node-1
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)