Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFCORE-5497 Multiple syntax issues with 'wildfly-init-debian.sh' #4649

Merged
merged 1 commit into from
Oct 21, 2021
Merged

WFCORE-5497 Multiple syntax issues with 'wildfly-init-debian.sh' #4649

merged 1 commit into from
Oct 21, 2021

Conversation

parsharma
Copy link
Contributor

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Jul 6, 2021
@wildfly-ci
Copy link

Core - Full Integration Build 10765 outcome was FAILURE using a merge of 7992dd5
Summary: Execution timeout (new); tests failed: 195 (195 new), passed: 4425, ignored: 2134 Build time: 10:00:29

Failed tests

org.wildfly.test.integration.microprofile.faulttolerance.context.asynchronous.AsynchronousRequestContextTestCase.testRequestContextActive: java.lang.AssertionError
	at org.wildfly.test.integration.microprofile.faulttolerance.context.asynchronous.AsynchronousRequestContextTestCase.testRequestContextActive(AsynchronousRequestContextTestCase.java:58)
	at org.jboss.as.arquillian.service.ArquillianService$ExtendedJMXTestRunner.doRunTestMethod(ArquillianService.java:200)
	at org.jboss.as.arquillian.service.ArquillianService$ExtendedJMXTestRunner.runTestMethod(ArquillianService.java:176)
	at com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:112)
	at com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:46)
	at com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237)
	at com.sun.jmx.mbeanserver.PerInterface.invoke(PerInterface.java:138)
	at com.sun.jmx.mbeanserver.MBeanSupport.invoke(MBeanSupport.java:252)
	at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:819)
	at com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:801)
	at org.jboss.as.jmx.PluggableMBeanServerImpl$TcclMBeanServer.invoke(PluggableMBeanServerImpl.java:1494)
	at org.jboss.as.jmx.PluggableMBeanServerImpl.invoke(PluggableMBeanServerImpl.java:727)
	at org.jboss.as.jmx.BlockingNotificationMBeanServer.invoke(BlockingNotificationMBeanServer.java:168)
	at org.jboss.as.jmx.AuthorizingMBeanServer.invoke(AuthorizingMBeanServer.java:258)
	at org.jboss.remotingjmx.protocol.v2.ServerProxy$InvokeHandler.handle(ServerProxy.java:950)
	at org.jboss.remotingjmx.protocol.v2.ServerCommon$MessageReciever$1$1.run(ServerCommon.java:153)
	at org.jboss.as.jmx.ServerInterceptorFactory$Interceptor$1.run(ServerInterceptorFactory.java:71)
	at org.jboss.as.jmx.ServerInterceptorFactory$Interceptor$1.run(ServerInterceptorFactory.java:66)
	at org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:328)
	at org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:285)
	at org.jboss.as.controller.AccessAuditContext.doAs(AccessAuditContext.java:254)
	at org.jboss.as.controller.AccessAuditContext.doAs(AccessAuditContext.java:225)
	at org.jboss.as.jmx.ServerInterceptorFactory$Interceptor.handleEvent(ServerInterceptorFactory.java:66)
	at org.jboss.remotingjmx.protocol.v2.ServerCommon$MessageReciever$1.run(ServerCommon.java:149)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)


org.wildfly.test.integration.microprofile.health.MicroProfileHealthSecuredHTTPEndpointTestCase.securedHTTPEndpointWithoutUserDefined: java.lang.AssertionError: expected:<401> but was:<200>
	at org.wildfly.test.integration.microprofile.health.MicroProfileHealthSecuredHTTPEndpointTestCase.securedHTTPEndpointWithoutUserDefined(MicroProfileHealthSecuredHTTPEndpointTestCase.java:71)


org.wildfly.test.integration.microprofile.health.MicroProfileHealthSecuredHTTPEndpointTestCase.securedHTTPEndpoint: java.lang.AssertionError: 'UP' message is expected
	at org.wildfly.test.integration.microprofile.health.MicroProfileHealthSecuredHTTPEndpointTestCase.securedHTTPEndpoint(MicroProfileHealthSecuredHTTPEndpointTestCase.java:93)


org.wildfly.test.integration.microprofile.health.MicroProfileHealthApplicationLiveOperationTestCase.testHealthCheckBeforeDeployment: 	at org.wildfly.test.integration.microprofile.health.MicroProfileHealthApplicationLiveOperationTestCase.checkGlobalOutcome(MicroProfileHealthApplicationLiveOperationTestCase.java:47)
	at org.wildfly.test.integration.microprofile.health.MicroProfileHealthApplicationLiveTestBase.testHealthCheckBeforeDeployment(MicroProfileHealthApplicationLiveTestBase.java:83)


org.wildfly.test.integration.microprofile.health.MicroProfileHealthApplicationLiveOperationTestCase.testHealthCheckAfterDeployment: 

org.wildfly.test.integration.microprofile.health.MicroProfileHealthApplicationLiveOperationTestCase.testHealthCheckAfterUndeployment: 	at org.wildfly.test.integration.microprofile.health.MicroProfileHealthApplicationLiveOperationTestCase.checkGlobalOutcome(MicroProfileHealthApplicationLiveOperationTestCase.java:47)
	at org.wildfly.test.integration.microprofile.health.MicroProfileHealthApplicationLiveTestBase.testHealthCheckAfterUndeployment(MicroProfileHealthApplicationLiveTestBase.java:118)


org.wildfly.test.integration.microprofile.health.MicroProfileHealthApplicationWithoutReadinessOperationTestCase.testApplicationReadinessBeforeDeployment: 	at org.wildfly.test.integration.microprofile.health.MicroProfileHealthApplicationWithoutReadinessOperationTestCase.checkGlobalOutcome(MicroProfileHealthApplicationWithoutReadinessOperationTestCase.java:47)
	at org.wildfly.test.integration.microprofile.health.MicroProfileHealthApplicationReadyTestBase.testApplicationReadinessBeforeDeployment(MicroProfileHealthApplicationReadyTestBase.java:78)


org.wildfly.test.integration.microprofile.health.MicroProfileHealthApplicationWithoutReadinessOperationTestCase.testApplicationReadinessAfterDeployment: 

org.wildfly.test.integration.microprofile.health.MicroProfileHealthApplicationWithoutReadinessOperationTestCase.testHealthCheckAfterUndeployment: 	at org.wildfly.test.integration.microprofile.health.MicroProfileHealthApplicationWithoutReadinessOperationTestCase.checkGlobalOutcome(MicroProfileHealthApplicationWithoutReadinessOperationTestCase.java:47)
	at org.wildfly.test.integration.microprofile.health.MicroProfileHealthApplicationReadyTestBase.testHealthCheckAfterUndeployment(MicroProfileHealthApplicationReadyTestBase.java:100)


org.wildfly.test.integration.microprofile.health.MicroProfileHealthApplicationLiveHTTPEndpointTestCase.testHealthCheckBeforeDeployment: javax.json.stream.JsonParsingException: JsonParser#getObject() or JsonParser#getObjectStream() is valid only for START_OBJECT parser state. But current parser state is START_ARRAY
	at org.glassfish.json.JsonReaderImpl.readObject(JsonReaderImpl.java:90)
	at org.wildfly.test.integration.microprofile.health.MicroProfileHealthApplicationLiveHTTPEndpointTestCase.checkGlobalOutcome(MicroProfileHealthApplicationLiveHTTPEndpointTestCase.java:75)
	at org.wildfly.test.integration.microprofile.health.MicroProfileHealthApplicationLiveTestBase.testHealthCheckBeforeDeployment(MicroProfileHealthApplicationLiveTestBase.java:83)
Caused by: java.lang.IllegalStateException: JsonParser#getObject() or JsonParser#getObjectStream() is valid only for START_OBJECT parser state. But current parser state is START_ARRAY
	at org.glassfish.json.JsonParserImpl.getObject(JsonParserImpl.java:147)
	at org.glassfish.json.JsonReaderImpl.readObject(JsonReaderImpl.java:88)
	... 124 more


org.wildfly.test.integration.microprofile.health.MicroProfileHealthApplicationLiveHTTPEndpointTestCase.testHealthCheckAfterDeployment: 


##### there are 185 more failed tests, see build details

@parsharma
Copy link
Contributor Author

@jfdenise could you please review this PR? There are four warnings that are left as the same left in this #4647.
Thanks

jfdenise
jfdenise reviewed Jul 9, 2021
View reviewed changes
...re-pack/common/src/main/resources/content/docs/contrib/scripts/init.d/wildfly-init-debian.sh
@@ -78,14 +78,13 @@ if [ -z "$JBOSS_USER" ]; then
fi

# Check wildfly user
id $JBOSS_USER > /dev/null 2>&1
if [ $? -ne 0 -o -z "$JBOSS_USER" ]; then
if ! id $JBOSS_USER > /dev/null 2>&1 || [ -z "$JBOSS_USER" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at: https://github.com/wildfly/wildfly-core/pull/4647/files#diff-2365dc492fe86de1f4e9838f06559da1b1ef830bf6f3955f7b66484b90c7a6e5R73
the change is different although I guess the same tooling has been used to suggest changes. Correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was giving a warning on this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I made mistake, I need to change the same line there as well. Thanks for noticing it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes done.

@github-actions
Copy link

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

@github-actions github-actions bot added the Stale label Sep 26, 2021
@parsharma
Copy link
Contributor Author

@jfdenise Could you please review this PR? Thanks

@github-actions github-actions bot removed the Stale label Sep 28, 2021
@yersan yersan added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Oct 21, 2021
@yersan yersan merged commit b215958 into wildfly:main Oct 21, 2021
@parsharma parsharma deleted the WFCORE-5497 branch May 9, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfdenise jfdenise jfdenise approved these changes

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Milestone
No milestone
4 participants
@parsharma @wildfly-ci @jfdenise @yersan