[WFCORE-5520] Avoid Nullpointer (host-controller) #4694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boris-unckel
force-pushed
the
WFCORE-5520_null_deref_hostcontroller
branch
from
e5818a7
to
1a6e3d7
Compare
github-actions
bot
added
the
deps-ok
yersan
requested changes
Aug 2, 2021
| if (localName == null) { | ||
| return null; | ||
| } | ||
| return MAP.get(localName.toLowerCase()); |
There was a problem hiding this comment.
This change is introducing an unexpected behavior change.
For example, if localName was something different of null and MAP.get(localName.toLowerCase()) returns null, this method was returning DirectoryGrouping.valueOf(localName.toUpperCase(Locale.ENGLISH)), but now it will return null.
There was a problem hiding this comment.
@yersan Hi Yeray, thanks for your feedback. It's fixed. Could you review and approve, please?
There was a problem hiding this comment.
Done, @boris-unckel, thanks!
boris-unckel
force-pushed
the
WFCORE-5520_null_deref_hostcontroller
branch
from
1a6e3d7
to
927421a
Compare
yersan
approved these changes
Aug 30, 2021
yersan
added
the
ready-for-merge
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.redhat.com/browse/WFCORE-5520