Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-5708] Add a new "org.wildfly.security.http.sfbasic" module. #4866

Merged
merged 3 commits into from
Dec 1, 2021

Conversation

darranl
Copy link
Contributor

@darranl darranl commented Nov 14, 2021

Added the hold label as this will require an update of WildFly Elytron but I need an upstream PR.

https://issues.redhat.com/browse/WFCORE-5708

@darranl darranl added the hold Do not merge this PR label Nov 14, 2021
@wildfly-ci
Copy link

Core - Full Integration Build 11159 outcome was FAILURE using a merge of fdc54ea
Summary: Exit code 1 (Step: Build & test core (Maven)) (new) Build time: 00:01:02

@wildfly-ci
Copy link

Core - Full Integration Build 11050 outcome was FAILURE using a merge of fdc54ea
Summary: Exit code 1 (Step: Build & test core (Maven)) (new) Build time: 00:01:47

@fjuma
Copy link
Contributor

fjuma commented Nov 26, 2021

Looks good, an update will also be needed in core-feature-pack-common-licenses.xml.

Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as approved, just needs an update in core-feature-pack-common-licenses.xml.

@wildfly-ci
Copy link

Core - Full Integration Build 11222 outcome was FAILURE using a merge of de289a5
Summary: Exit code 1 (Step: Build & test core (Maven)) Build time: 00:02:56

@wildfly-ci
Copy link

Core - Full Integration Build 11110 outcome was FAILURE using a merge of de289a5
Summary: Exit code 1 (Step: Build & test core (Maven)) Build time: 00:07:32

@darranl darranl mentioned this pull request Nov 26, 2021
@darranl darranl added ready-for-merge This PR is ready to be merged and fulfills all requirements and removed hold Do not merge this PR labels Nov 27, 2021
@wildfly-ci
Copy link

Core - Full Integration Build 11228 outcome was UNKNOWN using a merge of 61dd303
Summary: Canceled Build time: 00:00:42

@wildfly-ci
Copy link

Core - Full Integration Build 11116 outcome was UNKNOWN using a merge of 61dd303
Summary: Canceled Build time: 00:00:41

@wildfly-ci
Copy link

Core - Full Integration Build 11118 outcome was FAILURE using a merge of 61dd303
Summary: Tests failed: 1 (1 new), passed: 4092, ignored: 41 Build time: 02:05:17

Failed tests

org.jboss.as.test.layers.LayersTestCase.testServlet: java.lang.Exception: Some unreferenced modules are un-expected [org.wildfly.security.http.sfbasic]
	at org.jboss.as.test.layers.LayersTest.test(LayersTest.java:109)
	at org.jboss.as.test.layers.LayersTestCase.testServlet(LayersTestCase.java:146)


@wildfly-ci
Copy link

Core - Full Integration Build 11117 outcome was FAILURE using a merge of 61dd303
Summary: Tests failed: 1 (1 new), passed: 4091, ignored: 42 Build time: 02:08:44

Failed tests

org.jboss.as.test.layers.LayersTestCase.testServlet: java.lang.Exception: Some unreferenced modules are un-expected [org.wildfly.security.http.sfbasic]
	at org.jboss.as.test.layers.LayersTest.test(LayersTest.java:109)
	at org.jboss.as.test.layers.LayersTestCase.testServlet(LayersTestCase.java:146)


@gaol
Copy link
Contributor

gaol commented Nov 28, 2021

Maybe we need to add org.wildfly.security.http.sfbasic to NOT_USED in LayersTestCase of WildFly testsuite as well to pass Galleon Full Integration - Linux ?

The same for #4879

@darranl darranl removed the Critical label Nov 28, 2021
@gaol
Copy link
Contributor

gaol commented Nov 29, 2021

I opened a PR wildfly/wildfly#14970 to address the changes in wildfly

@yersan yersan added ready-for-merge This PR is ready to be merged and fulfills all requirements and removed ready-for-merge This PR is ready to be merged and fulfills all requirements labels Nov 30, 2021
@yersan yersan merged commit b38b043 into wildfly:main Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
5 participants