Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.x] Fix for WFCORE-5756, Upgrade bootable jar to 7.0.0.Final #4907

Merged
merged 1 commit into from Jan 10, 2022

Conversation

jfdenise
Copy link
Contributor

@jmesnil
Copy link
Member

jmesnil commented Jan 5, 2022

/ok-to-test

@jmesnil jmesnil added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Jan 6, 2022
@jmesnil
Copy link
Member

jmesnil commented Jan 7, 2022

@jfdenise I'm no longer sure we want to update bootable jar for this 18.xbranch. This branch is meant to be used for WildFly 26. I thought that the major bump for bootable jar version was aligned with WildFly version.
Should we stick to this match:

  • Bootable Jar 6.x -> WildFly 26.x
  • Bootable Jar 7.x -> WildFly 27.x

This question is also relevant for wildfly/wildfly#15045

@jmesnil jmesnil removed the ready-for-merge This PR is ready to be merged and fulfills all requirements label Jan 7, 2022
@bstansberry
Copy link
Contributor

@jmesnil I didn't see your comments here and merged wildfly/wildfly#15045. That can be reverted if need be. The 7 release looked like it was basically just moving to WF 26 for its examples, which seemed valid for a 26.x test fixture. But there may be something more to it.

@jfdenise
Copy link
Contributor Author

@jmesnil , 7.0.0.Final depends on WildFly 26, 6.0.0.Final depends on WildFly 25.0.0.Final. This is good to merge.

@jmesnil
Copy link
Member

jmesnil commented Jan 10, 2022

@jfdenise thanks!

@jmesnil jmesnil merged commit a3433cb into wildfly:18.x Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants