[WFCORE-5767] Add the Elytron OIDC Client related dependencies to Core #4917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 5, 2022
github-actions
bot
added
the
deps-ok
|
@boris-unckel Good question. Since these dependencies aren't actually being used by anything in Core and only get used by the Elytron OIDC layer in WildFly, I think we can leave these in the https://github.com/wildfly/wildfly/blob/main/elytron-oidc-client/galleon-common/src/main/resources/license/elytron-oidc-feature-pack-licenses.xml file. |
|
+1 this should not impact the modules provisioned by the core feature pack so should not need listing in the licenses. |
jmesnil
approved these changes
Jan 7, 2022
jmesnil
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFCORE-5767
Moving the Elytron OIDC Client related dependencies from WildFly to Core. The modules that actually make use of these dependencies will remain in WildFly.