WFCORE-1960: replace list of properties with map of strings #5049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
deps-ok
|
Core - Full Integration Build 11429 outcome was FAILURE using a merge of b3c9138 Failed tests |
|
Core - Full Integration Build 11296 outcome was FAILURE using a merge of b3c9138 Failed tests |
|
/retest |
|
Core - Full Integration Build 11441 outcome was FAILURE using a merge of b3c9138 |
|
Core - Full Integration Build 11305 outcome was FAILURE using a merge of b3c9138 |
|
/retest |
|
Core - Full Integration Build 11455 outcome was UNKNOWN using a merge of b3c9138 Failed tests |
|
Core - Full Integration Build 11316 outcome was UNKNOWN using a merge of b3c9138 Failed tests |
|
Core - Full Integration Build 11320 outcome was UNKNOWN using a merge of b3c9138 |
|
Core - Full Integration Build 11321 outcome was UNKNOWN using a merge of b3c9138 |
|
Core - Full Integration Build 11322 outcome was FAILURE using a merge of b3c9138 |
|
/retest |
1 similar comment
|
/retest |
|
There has been no activity on this PR for 45 days. It will be auto-closed after 90 days. |
michpetrov
force-pushed
the
wfcore-1960
branch
2 times, most recently
from
52c9c2b
to
d3f9c5b
Compare
yersan
reviewed
Jun 14, 2022
| public static final AttributeDefinition OWNER = PrimitiveListAttributeDefinition.Builder.of(ModelDescriptionConstants.OWNER, ModelType.PROPERTY) | ||
| .setRequired(false) | ||
| public static final AttributeDefinition OWNER = new SimpleMapAttributeDefinition.Builder(ModelDescriptionConstants.OWNER, ModelType.STRING, true) | ||
| .setCorrector(LIST_TO_MAP_CORRECTOR) |
There was a problem hiding this comment.
@michpetrov out of curiosity, why do you need to use a corrector here?
There was a problem hiding this comment.
I think I put it in there as a precaution, but it doesn't look it's needed so I'll remove it.
|
Core -> Full Integration Build 11512 outcome was FAILURE using a merge of e1495ce |
|
Core -> WildFly Preview Integration Build 11676 outcome was FAILURE using a merge of e1495ce |
|
Core -> Full Integration Build 11666 outcome was FAILURE using a merge of e1495ce |
|
Core -> Full Integration Build 11667 outcome was FAILURE using a merge of e1495ce |
|
Core -> Full Integration Build 11672 outcome was FAILURE using a merge of e1495ce |
yersan
approved these changes
Jun 16, 2022
yersan
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: WFCORE-1960