Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFCORE-5897 [primary/secondary] Problematic Language usage deprecation and replacement in testsuite #5108

Merged
merged 4 commits into from Sep 12, 2022

Conversation

parsharma
Copy link
Contributor

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label May 24, 2022
@yersan
Copy link
Collaborator

yersan commented May 27, 2022

Hi @parsharma , I would say we need to split the changes into at least three commits as described in the main issue. We should not add any change unrelated to each point, for example, do not change elytron security user names or auth contexts, or variable names, or whatever is not forced to be changed for each main point, just focus on the three points:

  1. Renaming the host-[master/slave].xml configuration files
  2. Rename the default DC hostname
  3. Rename properties used in the configuration files

That will ensure we are changing the tests accordingly and ensure we are not introducing wrong behaviors.

@parsharma
Copy link
Contributor Author

Thanks, @yersan, I have split the commits and pushed again. Right now there is only one commit that renames only host config files.

Copy link
Collaborator

@yersan yersan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @parsharma !

@parsharma parsharma marked this pull request as draft June 7, 2022 07:47
@wildfly wildfly deleted a comment from wildfly-ci Jun 14, 2022
@wildfly wildfly deleted a comment from wildfly-ci Jun 14, 2022
@wildfly wildfly deleted a comment from wildfly-ci Jun 14, 2022
@wildfly wildfly deleted a comment from wildfly-ci Jun 14, 2022
@wildfly wildfly deleted a comment from wildfly-ci Jun 14, 2022
@wildfly wildfly deleted a comment from wildfly-ci Jun 14, 2022
@wildfly wildfly deleted a comment from wildfly-ci Jun 14, 2022
@wildfly wildfly deleted a comment from wildfly-ci Jun 14, 2022
@wildfly wildfly deleted a comment from wildfly-ci Jun 14, 2022
@wildfly wildfly deleted a comment from wildfly-ci Jun 14, 2022
@parsharma parsharma force-pushed the WFCORE-5897 branch 3 times, most recently from 55be5bf to b86ee1f Compare July 19, 2022 14:25
@wildfly wildfly deleted a comment from wildfly-ci Jul 20, 2022
@wildfly wildfly deleted a comment from wildfly-ci Jul 20, 2022
@wildfly wildfly deleted a comment from wildfly-ci Jul 20, 2022
@wildfly wildfly deleted a comment from wildfly-ci Jul 20, 2022
@wildfly wildfly deleted a comment from wildfly-ci Sep 7, 2022
@wildfly wildfly deleted a comment from wildfly-ci Sep 7, 2022
@wildfly wildfly deleted a comment from wildfly-ci Sep 7, 2022
@wildfly wildfly deleted a comment from wildfly-ci Sep 7, 2022
@wildfly wildfly deleted a comment from wildfly-ci Sep 7, 2022
@wildfly wildfly deleted a comment from wildfly-ci Sep 7, 2022
@wildfly wildfly deleted a comment from wildfly-ci Sep 7, 2022
@wildfly wildfly deleted a comment from wildfly-ci Sep 7, 2022
@wildfly wildfly deleted a comment from wildfly-ci Sep 7, 2022
@wildfly wildfly deleted a comment from wildfly-ci Sep 7, 2022
@wildfly wildfly deleted a comment from wildfly-ci Sep 7, 2022
Copy link
Collaborator

@yersan yersan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yersan

CoreModelTestDelegate
ServerConfigTestCase

These two classes are not the part of test suite so I think we should not change it to primary.

These tests are part of wildfly-core-model-test-framework, which is used in the testsuite (both in WildFly Full and Core) we have to change them together with this PR to avoid the need of doing another integration between changes in WildFly Core that requires changes in full.

@wildfly wildfly deleted a comment from wildfly-ci Sep 9, 2022
@wildfly wildfly deleted a comment from wildfly-ci Sep 9, 2022
@wildfly wildfly deleted a comment from wildfly-ci Sep 9, 2022
@wildfly wildfly deleted a comment from wildfly-ci Sep 9, 2022
Copy link
Collaborator

@yersan yersan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm just only waiting to see the result of an integration Job in Windows.
@parsharma would you mind adding the Jira number to all the commits? Having a Jira number there is very useful when you are looking for the reason for a change in the GitHub history.

There is no need to trigger the CI Integration jobs again.

Linux: https://ci.wildfly.org/viewLog.html?buildId=324460
Windows: https://ci.wildfly.org/viewLog.html?buildId=324659

@parsharma
Copy link
Contributor Author

@yersan changes are done. Thanks

@wildfly-ci
Copy link

Core -> WildFly Preview Integration Build 11828 outcome was FAILURE using a merge of 33267ac
Summary: Tests passed: 2635, ignored: 25; compilation error: Compiler Build time: 01:05:31

@wildfly-ci
Copy link

Core -> Full Integration Build 11677 outcome was FAILURE using a merge of 33267ac
Summary: Tests passed: 4029, ignored: 48; compilation error: Compiler Build time: 01:44:36

@wildfly-ci
Copy link

Core -> Full Integration Build 11838 outcome was FAILURE using a merge of 33267ac
Summary: Tests passed: 7078, ignored: 134; compilation error: Compiler Build time: 03:15:42

@yersan yersan added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Sep 12, 2022
@yersan yersan merged commit 8463d90 into wildfly:main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
4 participants