New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WFCORE-5897 [primary/secondary] Problematic Language usage deprecation and replacement in testsuite #5108
Conversation
Hi @parsharma , I would say we need to split the changes into at least three commits as described in the main issue. We should not add any change unrelated to each point, for example, do not change elytron security user names or auth contexts, or variable names, or whatever is not forced to be changed for each main point, just focus on the three points:
That will ensure we are changing the tests accordingly and ensure we are not introducing wrong behaviors. |
Thanks, @yersan, I have split the commits and pushed again. Right now there is only one commit that renames only host config files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @parsharma !
...ed/src/main/java/org/jboss/as/test/integration/domain/management/util/DomainTestSupport.java
Show resolved
Hide resolved
55be5bf
to
b86ee1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CoreModelTestDelegate
ServerConfigTestCaseThese two classes are not the part of test suite so I think we should not change it to primary.
These tests are part of wildfly-core-model-test-framework
, which is used in the testsuite (both in WildFly Full and Core) we have to change them together with this PR to avoid the need of doing another integration between changes in WildFly Core that requires changes in full.
…of the relevant files used to configure the domain in the test suite
6a86f4f
to
dbc64fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'm just only waiting to see the result of an integration Job in Windows.
@parsharma would you mind adding the Jira number to all the commits? Having a Jira number there is very useful when you are looking for the reason for a change in the GitHub history.
There is no need to trigger the CI Integration jobs again.
Linux: https://ci.wildfly.org/viewLog.html?buildId=324460
Windows: https://ci.wildfly.org/viewLog.html?buildId=324659
….test.host.master.address, jboss.test.host.slave.address
dbc64fb
to
33267ac
Compare
@yersan changes are done. Thanks |
Core -> WildFly Preview Integration Build 11828 outcome was FAILURE using a merge of 33267ac |
Core -> Full Integration Build 11677 outcome was FAILURE using a merge of 33267ac |
Core -> Full Integration Build 11838 outcome was FAILURE using a merge of 33267ac |
Issue: https://issues.redhat.com/browse/WFCORE-5897