-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFLY-5950] Update client-side modular args to standard set that we s… #5137
Conversation
Core -> WildFly Preview Integration Build 11698 outcome was FAILURE using a merge of 82e19e8 Failed tests
|
TlsTestCase passes for me locally on SE 17 with this change. I don't get why it fails here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bstansberry the errors are logged for the wildfly-elytron-integration-jakarta
module:
[03:29:42] [INFO]
[03:29:42] [INFO] --- maven-surefire-plugin:2.22.2:test (default-test) @ wildfly-elytron-integration-jakarta ---
[03:29:42] [INFO]
[03:29:42] [INFO] -------------------------------------------------------
[03:29:42] [INFO] T E S T S
[03:29:42] [INFO] -------------------------------------------------------
It looks like you need to fix the properties not only for the elytron module, but also for wildfly-elytron-integration-jakarta
.
Look at
wildfly-core/jakartaee/elytron-jakarta/pom.xml
Lines 289 to 296 in 1e12e2b
<plugin> | |
<groupId>org.apache.maven.plugins</groupId> | |
<artifactId>maven-surefire-plugin</artifactId> | |
<configuration> | |
<reuseForks>false</reuseForks> | |
<argLine>-javaagent:${org.jmockit:jmockit:jar} ${surefire.jacoco.args} ${modular.jdk.args} -Dorg.wildfly.extension.elytron.restore-default-ssl-context=true -Dauthconfigprovider.factory=org.wildfly.security.auth.jaspi.ElytronAuthConfigFactory</argLine> | |
</configuration> | |
</plugin> |
…uggest user's use. Only use -add-opens=java.base/sun.security.ssl=ALL-UNNAMED in the elytron module which has a test that requires it.
Thanks, @yersan! Should be fixed now. |
Core -> Full Integration Build 11707 outcome was FAILURE using a merge of d37269e Failed tests
|
…uggest user's use.
Only use -add-opens=java.base/sun.security.ssl=ALL-UNNAMED in the elytron module which has a test that requires it.
https://issues.redhat.com/browse/WFCORE-5950