WFCORE-5953/WFCORE-5954: Fixing several YAML extension issues #5139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Extension. * Adding the operation to the list of operations to be processsed. Jira: https://issues.redhat.com/browse/WFCORE-5953 Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
github-actions
bot
added
the
deps-ok
* When a resource is empty we need to just add it. Jira: https://issues.redhat.com/browse/WFCORE-5954 Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
|
@ehsavoie would you mind reviewing this PR title? |
ehsavoie
changed the title
yersan
approved these changes
Jun 30, 2022
yersan
added
the
ready-for-merge
|
@ehsavoie would you mind backporting this to 18.x too? there are other YAML issues backported there so, if finally, we want to incorporate them we can incorporate all related |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes for YAML Extension: empty resources and list attributes
Jira: https://issues.redhat.com/browse/WFCORE-5953
https://issues.redhat.com/browse/WFCORE-5954