Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-6166] max-outbound-channels setting in remoting subsystem is not honored #5307

Merged
merged 1 commit into from Dec 13, 2022

Conversation

gaol
Copy link
Contributor

@gaol gaol commented Dec 5, 2022

@wildfly-ci
Copy link

Hello, gaol. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment.

@gaol
Copy link
Contributor Author

gaol commented Dec 5, 2022

This PR tries to set the optionMap from the subsystem configuration to the EndpointBuilder which was missed before.

To fully solve the issue, it also needs jboss-remoting/jboss-remoting#270 to be included to respect that.

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Dec 5, 2022
@yersan
Copy link
Collaborator

yersan commented Dec 5, 2022

/ok-to-test

@wildfly-ci
Copy link

Core -> Full Integration Build 12061 outcome was FAILURE using a merge of e8b3e09
Summary: Tests failed: 1 (1 new), passed: 7232, ignored: 160 Build time: 03:31:57

Failed tests

org.wildfly.extension.undertow.UndertowSubsystem10TestCase.testRuntime: java.lang.AssertionError: expected:<1> but was:<0>
	at org.wildfly.extension.undertow.AbstractUndertowSubsystemTestCase.testRuntime(AbstractUndertowSubsystemTestCase.java:176)
	at org.wildfly.extension.undertow.UndertowSubsystem10TestCase.testRuntime(UndertowSubsystem10TestCase.java:74)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)


@fl4via
Copy link
Contributor

fl4via commented Dec 9, 2022

This PR tries to set the optionMap from the subsystem configuration to the EndpointBuilder which was missed before.

To fully solve the issue, it also needs jboss-remoting/jboss-remoting#270 to be included to respect that.

The JBoss Remoting fix will be included in WildFly Core once #5312 is merged.

@yersan yersan changed the title [WFLY-14961] max-outbound-channels setting in remoting subsystem is not honored [WFCORE-6166] max-outbound-channels setting in remoting subsystem is not honored Dec 12, 2022
@yersan yersan merged commit 4529216 into wildfly:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
5 participants