Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFCORE-6141][WFCORE-6156][WFCORE-6157][WFCORE-6158] Server Stability Fixes #5311

Merged
merged 4 commits into from Dec 12, 2022
Merged

[WFCORE-6141][WFCORE-6156][WFCORE-6157][WFCORE-6158] Server Stability Fixes #5311

merged 4 commits into from Dec 12, 2022

Conversation

ropalka
Copy link
Contributor

@ropalka ropalka commented Dec 7, 2022

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Dec 7, 2022
@wildfly-ci
Copy link

Core -> Full Integration Build 12066 outcome was FAILURE using a merge of 21d0e80
Summary: Tests failed: 1 (1 new), passed: 7162, ignored: 129 Build time: 03:51:17

Failed tests

org.jboss.as.clustering.jgroups.subsystem.JGroupsTransformersTestCase.testRejectionsEAP740: java.lang.RuntimeException: org.eclipse.aether.resolution.ArtifactResolutionException: Could not transfer artifact org.jboss.eap:wildfly-clustering-jgroups-extension:jar:7.4.0.GA-redhat-00005 from/to repo0 (http://nexus.wildfly.int/nexus/repository/public/): Connect to nexus.wildfly.int:80 timed out
	at org.jboss.as.model.test.MavenUtil.createMavenGavURL(MavenUtil.java:142)
	at org.jboss.as.model.test.ChildFirstClassLoaderBuilder.addMavenResourceURL(ChildFirstClassLoaderBuilder.java:198)
	at org.jboss.as.subsystem.test.SubsystemTestDelegate$LegacyKernelServiceInitializerImpl.addMavenResourceURL(SubsystemTestDelegate.java:712)
	at org.jboss.as.clustering.jgroups.subsystem.JGroupsTransformersTestCase.testRejections(JGroupsTransformersTestCase.java:137)
	at org.jboss.as.clustering.jgroups.subsystem.JGroupsTransformersTestCase.testRejectionsEAP740(JGroupsTransformersTestCase.java:124)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Caused by: org.eclipse.aether.resolution.ArtifactResolutionException: Could not transfer artifact org.jboss.eap:wildfly-clustering-jgroups-extension:jar:7.4.0.GA-redhat-00005 from/to repo0 (http://nexus.wildfly.int/nexus/repository/public/): Connect to nexus.wildfly.int:80 timed out
	at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:422)
	at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:224)
	at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact(DefaultArtifactResolver.java:201)
	at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveArtifact(DefaultRepositorySystem.java:260)
	at org.jboss.as.model.test.MavenUtil.createMavenGavURL(MavenUtil.java:140)
	... 34 more
Caused by: org.eclipse.aether.transfer.ArtifactTransferException: Could not transfer artifact org.jboss.eap:wildfly-clustering-jgroups-extension:jar:7.4.0.GA-redhat-00005 from/to repo0 (http://nexus.wildfly.int/nexus/repository/public/): Connect to nexus.wildfly.int:80 timed out
	at org.eclipse.aether.connector.basic.ArtifactTransportListener.transferFailed(ArtifactTransportListener.java:52)
	at org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run(BasicRepositoryConnector.java:365)
	at org.eclipse.aether.util.concurrency.RunnableErrorForwarder$1.run(RunnableErrorForwarder.java:75)
	at org.eclipse.aether.connector.basic.BasicRepositoryConnector$DirectExecutor.execute(BasicRepositoryConnector.java:583)
	at org.eclipse.aether.connector.basic.BasicRepositoryConnector.get(BasicRepositoryConnector.java:259)
	at org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads(DefaultArtifactResolver.java:498)
	at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:399)
	... 38 more
Caused by: org.apache.http.conn.ConnectTimeoutException: Connect to nexus.wildfly.int:80 timed out
	at org.apache.http.conn.scheme.PlainSocketFactory.connectSocket(PlainSocketFactory.java:123)
	at org.apache.http.impl.conn.DefaultClientConnectionOperator.openConnection(DefaultClientConnectionOperator.java:180)
	at org.apache.http.impl.conn.ManagedClientConnectionImpl.open(ManagedClientConnectionImpl.java:326)
	at org.apache.http.impl.client.DefaultRequestDirector.tryConnect(DefaultRequestDirector.java:605)
	at org.apache.http.impl.client.DefaultRequestDirector.execute(DefaultRequestDirector.java:440)
	at org.apache.http.impl.client.AbstractHttpClient.doExecute(AbstractHttpClient.java:835)
	at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:72)
	at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:56)
	at org.apache.http.impl.client.DecompressingHttpClient.execute(DecompressingHttpClient.java:164)
	at org.eclipse.aether.transport.http.HttpTransporter.execute(HttpTransporter.java:296)
	at org.eclipse.aether.transport.http.HttpTransporter.implGet(HttpTransporter.java:252)
	at org.eclipse.aether.spi.connector.transport.AbstractTransporter.get(AbstractTransporter.java:67)
	at org.eclipse.aether.connector.basic.BasicRepositoryConnector$GetTaskRunner.runTask(BasicRepositoryConnector.java:453)
	at org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run(BasicRepositoryConnector.java:360)
	... 43 more

@ropalka
[WFCORE-6156] Use ServiceContainer.awaitStability() instead of Stabil…
b264875 
…ityMonitor.awaitStability() in ContainerStateMonitor to ensure proper stability of services.
@ropalka
[WFCORE-6157] Forbid interruption of operation thread awaiting contai…
a9bb73d 
…ner stability to prevent leaving server in inconsistent state. Notice it is still the case server will not block forever when operation timeout is configured.
@ropalka
[WFCORE-6158] Add information about what needs to be investigated
a31e41f
@ropalka
Revert "[WFCORE-6141] Fixing transient test failures" - it was fixed …
4240d1e 
…by WFCORE-6156

This reverts commit 0ef150f.
@yersan yersan changed the title Server Stability Fixes [WFCORE-6141][WFCORE-6156][WFCORE-6157][WFCORE-6158] Server Stability Fixes Dec 12, 2022
yersan
yersan reviewed Dec 12, 2022
View reviewed changes
controller/src/test/java/org/jboss/as/controller/OperationCancellationUnitTestCase.java
import org.junit.Test;

/**
* Unit tests of {@link ModelControllerImpl}.
*
* @author Brian Stansberry (c) 2011 Red Hat Inc.
*/
@org.junit.Ignore
@Ignore("WFCORE-6158")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ropalka , would you mind adding a short description to WFCORE-6158? It is unclear your intention with this Jira, I'm going to merge this PR since I understand WFCORE-6158 is in place to just investigate whether this test case must be removed, but I'll leave the Jira unresolved until it is clear what you want to do with this case.

yersan
yersan reviewed Dec 12, 2022
View reviewed changes
controller/src/main/java/org/jboss/as/controller/OperationContextImpl.java
@@ -846,7 +846,7 @@ private void ensureWriteLockForRuntime() {
ExecutionStatus origStatus = executionStatus;
try {
executionStatus = ExecutionStatus.AWAITING_STABILITY;
modelController.awaitContainerStability(timeout, TimeUnit.MILLISECONDS, false);
modelController.awaitContainerStability(timeout, TimeUnit.MILLISECONDS, false); // interruption forbidden - see WFCORE-6158
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you wanted to use see WFCORE-6157, instead of seeing WFCORE-6158. We can correct it after merging, but could you confirm @ropalka ?

@yersan yersan added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Dec 12, 2022
@yersan yersan merged commit 5c24220 into wildfly:main Dec 12, 2022
@ropalka ropalka deleted the stability-fixes branch December 12, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yersan yersan yersan approved these changes

@bstansberry bstansberry Awaiting requested review from bstansberry

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Milestone
No milestone
3 participants
@ropalka @wildfly-ci @yersan