Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.x][WFCORE-6168] Write server configuration files using UTF-8 encoding a… #5322

Merged
merged 1 commit into from Dec 13, 2022
Merged

[19.x][WFCORE-6168] Write server configuration files using UTF-8 encoding a… #5322

merged 1 commit into from Dec 13, 2022

Conversation

yersan
Copy link
Collaborator

@yersan yersan commented Dec 13, 2022

…nd force to write the XML encoding header

Jira issue: https://issues.redhat.com/browse/WFCORE-6168

@yersan yersan added the 19.x label Dec 13, 2022
@yersan yersan changed the title [WFCORE-6168] Write server configuration files using UTF-8 encoding a… [19.x][WFCORE-6168] Write server configuration files using UTF-8 encoding a… Dec 13, 2022
bstansberry
bstansberry requested changes Dec 13, 2022
View reviewed changes
...st/java/org/jboss/as/test/manualmode/management/persistence/EncodingPersistenceTestCase.java Outdated
Comment on lines 93 to 102
try (Stream<Path> file = Files.list(domain)) {
file.filter(p -> p.toString().endsWith(".xml")).forEach(this::checkXmlHeader);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block needs to be guarded with a Files.exists check.

@wildfly-ci
Copy link

Core -> Full Integration Build 19 outcome was FAILURE using a merge of f713ce9
Summary: Tests failed: 1 (1 new), passed: 4045, ignored: 49 Build time: 01:57:52

Failed tests

org.jboss.as.test.clustering.cluster.singleton.SingletonBackupServiceTestCase.testSingletonService: 	at org.jboss.as.test.clustering.cluster.singleton.SingletonBackupServiceTestCase.testSingletonService(SingletonBackupServiceTestCase.java:92)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor3.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor3.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
------- Stdout: -------
node-2  [0m13:44:12,249 INFO  [org.jboss.as.repository] (management-handler-thread - 1) WFLYDR0001: Content added at location /opt/buildAgent/work/b89a8b3e59b261bf/full/testsuite/integration/clustering/target/wildfly-clustering-singleton-ha-2/standalone/data/content/7a/c6d0cc79fe264cb1e76ab87a593a96edcddc9f/content
 [0mnode-2  [0m13:44:12,252 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-5) WFLYSRV0027: Starting deployment of "SingletonBackupServiceTestCase.war" (runtime-name: "SingletonBackupServiceTestCase.war")
 [0mnode-2  [33m13:44:12,356 WARN  [org.jboss.as.dependency.private] (MSC service thread 1-3) WFLYSRV0018: Deployment "deployment.SingletonBackupServiceTestCase.war" is using a private module ("org.jboss.as.server") which may be changed or removed in future versions without notice.
 [0mnode-2  [0m13:44:12,465 INFO  [org.wildfly.extension.undertow] (ServerService Thread Pool -- 16) WFLYUT0021: Registered web context: '/SingletonBackupServiceTestCase' for server 'default-server'
 [0mnode-2  [0m13:44:12,536 INFO  [org.jboss.as.clustering.jgroups] (ServerService Thread Pool -- 16) WFLYCLJG0032: Connecting 'ee' channel. 'node-2' joining cluster 'ejb' via /0:0:0:0:0:0:0:1:7700
 [0mnode-2  [0m13:44:12,536 INFO  [org.jgroups.JChannel] (ServerService Thread Pool -- 16) local_addr: ba9c2907-6ae4-4650-b1e5-d8c25f346c0f, name: node-2
 [0mnode-2  [0m13:44:12,541 INFO  [org.jgroups.protocols.FD_SOCK2] (ServerService Thread Pool -- 16) server listening on /0:0:0:0:0:0:0:1:57700
 [0mnode-2  [0m13:44:14,546 INFO  [org.jgroups.protocols.pbcast.GMS] (ServerService Thread Pool -- 16) node-2: no members discovered after 2000 ms: creating cluster as coordinator
 [0mnode-2  [0m13:44:14,548 INFO  [org.jboss.as.clustering.jgroups] (ServerService Thread Pool -- 16) WFLYCLJG0033: Connected 'ee' channel. 'node-2' joined cluster 'ejb' with view: [node-2|0] (1) [node-2]
 [0mnode-2  [0m13:44:14,580 INFO  [org.infinispan.CONTAINER] (ServerService Thread Pool -- 16) ISPN000389: Loaded global state, version=14.0.2.Final timestamp=2022-12-13T13:44:11.996189Z
 [0mnode-2  [0m13:44:14,587 INFO  [org.infinispan.CONTAINER] (ServerService Thread Pool -- 16) ISPN000556: Starting user marshaller 'org.wildfly.clustering.infinispan.marshall.InfinispanProtoStreamMarshaller'
 [0mnode-2  [0m13:44:14,589 INFO  [org.infinispan.CLUSTER] (ServerService Thread Pool -- 16) ISPN000078: Starting JGroups channel `ejb`
 [0mnode-2  [0m13:44:14,591 INFO  [org.infinispan.CLUSTER] (ServerService Thread Pool -- 16) ISPN000094: Received new cluster view for channel ejb: [node-2|0] (1) [node-2]
 [0mnode-2  [0m13:44:14,595 INFO  [org.infinispan.CLUSTER] (ServerService Thread Pool -- 16) ISPN000079: Channel `ejb` local address is `node-2`, physical addresses are `[0:0:0:0:0:0:0:1:7700]`
 [0mnode-2  [0m13:44:14,647 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 16) WFLYCLINF0002: Started default cache from server container
 [0mnode-2  [0m13:44:14,688 INFO  [org.jboss.as.server] (management-handler-thread - 1) WFLYSRV0010: Deployed "SingletonBackupServiceTestCase.war" (runtime-name : "SingletonBackupServiceTestCase.war")
 [0mnode-1  [0m13:44:14,767 INFO  [org.jboss.as.repository] (management-handler-thread - 2) WFLYDR0001: Content added at location /opt/buildAgent/work/b89a8b3e59b261bf/full/testsuite/integration/clustering/target/wildfly-clustering-singleton-ha-1/standalone/data/content/15/312358242bb67842e0000679e622046a13aaf1/content

@bstansberry bstansberry merged commit ea687fd into wildfly:19.x Dec 13, 2022
@yersan yersan deleted the WFCORE-6168-19.x branch December 13, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstansberry bstansberry bstansberry requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@yersan @wildfly-ci @bstansberry