[WFCORE-6198] DelegatingModelControllerClient.close should handle a missing client #5350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
deps-ok
|
Core -> Full Integration Build 11942 outcome was FAILURE using a merge of 36bfd41 Failed tests |
|
Core -> Full Integration Build 12140 outcome was FAILURE using a merge of 36bfd41 Failed tests |
|
Core -> Full Integration Build 11943 outcome was FAILURE using a merge of 36bfd41 Failed tests |
yersan
reviewed
Jan 16, 2023
There was a problem hiding this comment.
@soul2zimate, one doubt, looking at the anonymous implementation:
public DelegatingModelControllerClient(final ModelControllerClient delegate) {
this(new DelegateProvider() {
@Override
public ModelControllerClient getDelegate() {
return delegate;
}
});
}
Since it doesn't throw an ISE, shouldn't at least this anonymous implementation check the delegate argument is not null to fully satisfice the getDelegate() API?
|
|
|
Core -> WildFly Preview Integration Build 12079 outcome was FAILURE using a merge of 07801d8 Failed tests |
|
Core -> Full Integration Build 12147 outcome was FAILURE using a merge of 07801d8 Failed tests |
soul2zimate
force-pushed
the
WFCORE-6198-main
branch
from
07801d8
to
4a1757d
Compare
yersan
approved these changes
Jan 17, 2023
yersan
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/WFCORE-6198