New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFCORE-6211] Remove ModuleIdentifier from ServiceModuleLoader.preloadModule #5362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just by changing this method, the base ModuleLoader
class should no longer construct the useless intermediate ModuleIdentifier
which causes the perf problem. 👍
Core -> Full Integration Build 11964 outcome was FAILURE using a merge of c684d3f Failed tests
|
Core -> Full Integration Build 12162 outcome was FAILURE using a merge of c684d3f Failed tests
|
I'm rerunning one of the failed jobs, but failed tests didn't seem relevant. |
Core -> Full Integration Build 11969 outcome was FAILURE using a merge of c684d3f Failed tests
|
Core -> Full Integration Build 11971 outcome was FAILURE using a merge of c684d3f Failed tests
|
Core -> Full Integration Build 11974 outcome was FAILURE using a merge of c684d3f Failed tests
|
Core -> Full Integration Build 11975 outcome was UNKNOWN using a merge of c684d3f |
Core -> Full Integration Build 11976 outcome was FAILURE using a merge of c684d3f Failed tests
|
https://issues.redhat.com/browse/WFCORE-6211