Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-6245] Eliminating deprecated ibm.jdk module usages #5399

Merged
merged 1 commit into from Apr 4, 2023

Conversation

ropalka
Copy link
Contributor

@ropalka ropalka commented Mar 1, 2023

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Mar 1, 2023
@wildfly-ci
Copy link

Core -> WildFly Preview Integration Build 12171 outcome was FAILURE using a merge of 0431b00
Summary: Tests failed: 1 (1 new), passed: 2772, ignored: 44 Build time: 01:39:33

Failed tests

org.jboss.as.test.layers.LayersTestCase.test: java.lang.Exception: ERROR, some modules have not been provisioned: ibm.jdk,
	at org.jboss.as.test.layers.LayersTest.test(LayersTest.java:133)
	at org.jboss.as.test.layers.LayersTestCase.test(LayersTestCase.java:315)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)


@wildfly-ci
Copy link

Core -> Full Integration Build 12054 outcome was FAILURE using a merge of 0431b00
Summary: Tests failed: 1 (1 new), passed: 4095, ignored: 50 Build time: 02:24:00

Failed tests

org.jboss.as.test.layers.LayersTestCase.test: java.lang.Exception: ERROR, some modules have not been provisioned: ibm.jdk,
	at org.jboss.as.test.layers.LayersTest.test(LayersTest.java:133)
	at org.jboss.as.test.layers.LayersTestCase.test(LayersTestCase.java:315)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)


@ropalka
Copy link
Contributor Author

ropalka commented Mar 3, 2023

This PR depends on wildfly/wildfly#16572 to be merged first

@bstansberry
Copy link
Contributor

@ropalka This needs some discussion on the wildfly-dev list. I believe the ServerRootResourceDefinition change means this module will no longer be provisioned in a slimmed server. And we have no simple way of ensuring it is provisioned, e.g. a layer. And I don't want a layer. :)

Then there's the aspect of SE packages no longer being available.

I'd like this on the discussed on the list so it gets greater visibility.

@bstansberry
Copy link
Contributor

The JIRA description should have more details as well. I don't know why this change is being made and only by painful code history and JIRA detective work could I come to a rough guess. The module is deprecated, but the history is not explicit about why. I assume the idea is we shouldn't be exposing SE internals.

@ropalka
Copy link
Contributor Author

ropalka commented Mar 10, 2023

I'm working in both areas @bstansberry . I'm preparing the information email for discussion on wildfly-dev ML and collecting information to add to relevant JIRAs.

@darranl darranl marked this pull request as draft March 27, 2023 14:05
@darranl
Copy link
Contributor

darranl commented Mar 27, 2023

FYI I have just converted to a draft as it has been identified there needs to be ongoing discussion first.

@yersan yersan marked this pull request as ready for review April 4, 2023 11:21
@yersan
Copy link
Collaborator

yersan commented Apr 4, 2023

@ropalka FYI

I'm moving this to "Ready For Review", there will be future work removing completely this module from WildFly, although it can be removed now, I'm assuming we want it fully removed on the next release.

Since the WildFly counterpart PR was already merged, we could get this one merged as it is for WildFly Core 20.0.0. Final

@ropalka
Copy link
Contributor Author

ropalka commented Apr 4, 2023

Yes, we will remove ibm.jdk module in next release @yersan .

@yersan yersan added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Apr 4, 2023
@yersan yersan merged commit 05a233f into wildfly:main Apr 4, 2023
2 checks passed
@ropalka ropalka deleted the WFCORE-6245 branch April 4, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
5 participants