[WFCORE-6249] Eliminating deprecated sun.jdk module usages #5445

ropalka · 2023-04-06T18:26:14Z

https://issues.redhat.com/browse/WFCORE-6249

testsuite/layers/src/test/java/org/jboss/as/test/layers/LayersTestCase.java

...ture-pack/common/src/main/resources/modules/system/layers/base/sun/scripting/main/module.xml

wildfly-ci · 2023-04-14T12:28:52Z

Core -> Full Integration Build 12212 outcome was FAILURE using a merge of a3a14e8
Summary: Tests failed: 1 (1 new), passed: 4013, ignored: 61 Build time: 02:55:59

Failed tests

org.wildfly.test.integration.observability.opentelemetry.ContextPropagationTestCase(layers-test).testContextPropagation: java.lang.AssertionError: Failed to get expected spans. Got:
Recording traceparent
/ContextPropagationTestCase/contextProp2
HTTP GET
Making second request
/ContextPropagationTestCase/contextProp1
java.lang.AssertionError: 
Failed to get expected spans. Got:
Recording traceparent
/ContextPropagationTestCase/contextProp2
HTTP GET
Making second request
/ContextPropagationTestCase/contextProp1
	at deployment.ContextPropagationTestCase.war//org.wildfly.test.integration.observability.opentelemetry.exporter.InMemorySpanExporter.assertSpanCount(InMemorySpanExporter.java:61)
	at deployment.ContextPropagationTestCase.war//org.wildfly.test.integration.observability.opentelemetry.exporter.InMemorySpanExporter.getFinishedSpanItems(InMemorySpanExporter.java:50)
	at deployment.ContextPropagationTestCase.war//org.wildfly.test.integration.observability.opentelemetry.exporter.InMemorySpanExporter$Proxy$_$$_WeldClientProxy.getFinishedSpanItems(Unknown Source)
	at deployment.ContextPropagationTestCase.war//org.wildfly.test.integration.observability.opentelemetry.ContextPropagationTestCase.testContextPropagation(ContextPropagationTestCase.java:68)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at deployment.arquillian-service//org.jboss.as.arquillian.service.ArquillianService$ExtendedJMXTestRunner.doRunTestMethod(ArquillianService.java:202)
	at deployment.arquillian-service//org.jboss.as.arquillian.service.ArquillianService$ExtendedJMXTestRunner.runTestMethod(ArquillianService.java:178)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)

wildfly-ci · 2023-04-14T18:18:00Z

Core -> Full Integration Build 12213 outcome was FAILURE using a merge of a3a14e8
Summary: Tests failed: 1, passed: 4013, ignored: 61 Build time: 02:03:35

Failed tests

org.wildfly.test.integration.observability.opentelemetry.ContextPropagationTestCase(layers-test).testContextPropagation: java.lang.AssertionError: Failed to get expected spans. Got:
Recording traceparent
/ContextPropagationTestCase/contextProp2
HTTP GET
Making second request
/ContextPropagationTestCase/contextProp1
java.lang.AssertionError: 
Failed to get expected spans. Got:
Recording traceparent
/ContextPropagationTestCase/contextProp2
HTTP GET
Making second request
/ContextPropagationTestCase/contextProp1
	at deployment.ContextPropagationTestCase.war//org.wildfly.test.integration.observability.opentelemetry.exporter.InMemorySpanExporter.assertSpanCount(InMemorySpanExporter.java:61)
	at deployment.ContextPropagationTestCase.war//org.wildfly.test.integration.observability.opentelemetry.exporter.InMemorySpanExporter.getFinishedSpanItems(InMemorySpanExporter.java:50)
	at deployment.ContextPropagationTestCase.war//org.wildfly.test.integration.observability.opentelemetry.exporter.InMemorySpanExporter$Proxy$_$$_WeldClientProxy.getFinishedSpanItems(Unknown Source)
	at deployment.ContextPropagationTestCase.war//org.wildfly.test.integration.observability.opentelemetry.ContextPropagationTestCase.testContextPropagation(ContextPropagationTestCase.java:68)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at deployment.arquillian-service//org.jboss.as.arquillian.service.ArquillianService$ExtendedJMXTestRunner.doRunTestMethod(ArquillianService.java:202)
	at deployment.arquillian-service//org.jboss.as.arquillian.service.ArquillianService$ExtendedJMXTestRunner.runTestMethod(ArquillianService.java:178)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)

ropalka · 2023-04-17T09:19:48Z

Hello @yersan this PR is awaiting your approval.

yersan · 2023-04-17T10:41:58Z

Hi @ropalka , yes, I'm keeping an eye on it, we need to go with full confidence at this stage and "
Galleon Full integration - Linux" failed twice with your latest changes, apparently it is unrelated, but better to go with all in gree for now

yersan · 2023-04-17T15:57:13Z

Thanks @ropalka

[WFCORE-6249] Eliminating deprecated sun.jdk module usages

ddba8b0

github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Apr 6, 2023

yersan requested changes Apr 12, 2023

View reviewed changes

testsuite/layers/src/test/java/org/jboss/as/test/layers/LayersTestCase.java Show resolved Hide resolved

bstansberry requested changes Apr 12, 2023

View reviewed changes

...ture-pack/common/src/main/resources/modules/system/layers/base/sun/scripting/main/module.xml Outdated Show resolved Hide resolved

[WFCORE-6301] Preparing sun.scripting private module for removal

a3a14e8

ropalka force-pushed the WFCORE-6249 branch from 67bf557 to a3a14e8 Compare April 13, 2023 08:25

bstansberry approved these changes Apr 13, 2023

View reviewed changes

wildfly deleted a comment from wildfly-ci Apr 14, 2023

yersan approved these changes Apr 17, 2023

View reviewed changes

yersan added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Apr 17, 2023

yersan merged commit e26bec0 into wildfly:main Apr 17, 2023
12 checks passed

ropalka deleted the WFCORE-6249 branch April 18, 2023 08:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WFCORE-6249] Eliminating deprecated sun.jdk module usages #5445

[WFCORE-6249] Eliminating deprecated sun.jdk module usages #5445

ropalka commented Apr 6, 2023

wildfly-ci commented Apr 14, 2023

wildfly-ci commented Apr 14, 2023

ropalka commented Apr 17, 2023

yersan commented Apr 17, 2023

yersan commented Apr 17, 2023

[WFCORE-6249] Eliminating deprecated sun.jdk module usages #5445

[WFCORE-6249] Eliminating deprecated sun.jdk module usages #5445

Conversation

ropalka commented Apr 6, 2023

wildfly-ci commented Apr 14, 2023

Failed tests

wildfly-ci commented Apr 14, 2023

Failed tests

ropalka commented Apr 17, 2023

yersan commented Apr 17, 2023

yersan commented Apr 17, 2023