Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-587] Wildfly does not log stack trace of an exception #546

Merged
merged 1 commit into from Mar 13, 2015

Conversation

TomasHofman
Copy link
Contributor

@wildfly-ci
Copy link

Core - Full Integration Build 592 is now running using a merge of 3197d48

@wildfly-ci
Copy link

Linux Build 1340 is now running using a merge of 3197d48

@wildfly-ci
Copy link

Windows Build 1012 is now running using a merge of 3197d48

@wildfly-ci
Copy link

Linux Build 1340 outcome was SUCCESS using a merge of 3197d48
Summary: Tests passed: 3047, ignored: 64 Build time: 0:19:05

@wildfly-ci
Copy link

Windows Build 1012 outcome was FAILURE using a merge of 3197d48
Summary: Execution timeout (new); tests passed: 2813, ignored: 52; org.wildfly.core:wildfly-core-testsuite-domain Build time: 0:45:06

Build problems:

Execution timeout
Process exited with code 1

@wildfly-ci
Copy link

Core - Full Integration Build 592 outcome was SUCCESS using a merge of 3197d48
Summary: Tests passed: 2832, ignored: 415 Build time: 0:48:41

@bstansberry
Copy link
Contributor

This doesn't fix the problem (the "report" method doesn't log anything) and it unnecessarily rearranges imports to not follow the WildFly standard.

@bstansberry bstansberry added the fixme This PR introduces issues that must be fixed label Mar 10, 2015
@dmlloyd
Copy link
Member

dmlloyd commented Mar 11, 2015

This fix is completely wrong anyway. If you want the stack trace to be logged, just add @Cause to tge exception parameter and drop the corresponding part from the format string.

@bstansberry
Copy link
Contributor

I don't want the stack trace in the output to report(...) though. That's an out-of-band message theoretically back to the client, which currently goes nowhere. I don't want to be sending server side stack traces to the client.

There just needs to be a new log method to log this.

@TomasHofman
Copy link
Contributor Author

OK, I will direct it into log instead. Thanks for comments!

@TomasHofman
Copy link
Contributor Author

So I left the original report message without change but also logged it with a stack trace.

@wildfly-ci
Copy link

Core - Full Integration Build 620 is now running using a merge of cd484e4

@wildfly-ci
Copy link

Linux Build 1369 is now running using a merge of cd484e4

@wildfly-ci
Copy link

Windows Build 1040 is now running using a merge of cd484e4

@wildfly-ci
Copy link

Windows Build 1040 outcome was SUCCESS using a merge of cd484e4
Summary: Tests passed: 3073, ignored: 64 Build time: 0:19:06

@wildfly-ci
Copy link

Linux Build 1369 outcome was SUCCESS using a merge of cd484e4
Summary: Tests passed: 3073, ignored: 64 Build time: 0:19:21

@wildfly-ci
Copy link

Core - Full Integration Build 620 outcome was FAILURE using a merge of cd484e4
Summary: Tests failed: 1 (1 new), passed: 2829, ignored: 412 Build time: 0:49:33

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.ws.wsse.signencrypt.EJBSignEncryptMultipleClientsTestCase.encryptedAndSignedRequestFromAlice: javax.xml.ws.WebServiceException: Could not send Message.
    at java.net.SocketInputStream.socketRead0(Native Method)
    at java.net.SocketInputStream.read(SocketInputStream.java:150)

@bstansberry bstansberry added ready-for-merge This PR is ready to be merged and fulfills all requirements and removed fixme This PR introduces issues that must be fixed labels Mar 12, 2015
bstansberry added a commit that referenced this pull request Mar 13, 2015
[WFCORE-587] Wildfly does not log stack trace of an exception
@bstansberry bstansberry merged commit 27a4814 into wildfly:master Mar 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
4 participants