Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-6312] Add version 18 of the WildFly Elytron model and schema #5463

Merged
merged 3 commits into from
May 26, 2023

Conversation

fjuma
Copy link
Contributor

@fjuma fjuma commented Apr 21, 2023

https://issues.redhat.com/browse/WFCORE-6312

Creating this as a draft PR for now since we have at least one RFE being worked on right now that needs this. This can be merged once we have an RFE that has been pre-checked.

@fjuma fjuma marked this pull request as ready for review May 19, 2023 21:43
@yersan
Copy link
Collaborator

yersan commented May 23, 2023

CC @ehsavoie since he can help with the yaml failures

@fjuma
Copy link
Contributor Author

fjuma commented May 23, 2023

@ehsavoie Would you be able to help with the yaml failures? I haven't been able to look closely yet but I'm not sure where it's getting the urn:wildfly:elytron:17.0 value from since it looks like I've updated that to urn:wildfly:elytron:18.0 in most places. Thanks!

Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
@ehsavoie
Copy link
Contributor

@fjuma PR sent on your branch fjuma#4

[WFCORE-6312] Fixing testsuite YAML failures
@fjuma
Copy link
Contributor Author

fjuma commented May 24, 2023

Thanks very much @yersan and @ehsavoie! I've just merged @ehsavoie's PR against my branch.

@wildfly wildfly deleted a comment from wildfly-ci May 25, 2023
@wildfly wildfly deleted a comment from wildfly-ci May 25, 2023
@wildfly wildfly deleted a comment from wildfly-ci May 25, 2023
@yersan yersan requested a review from darranl May 25, 2023 07:52
@yersan yersan mentioned this pull request May 25, 2023
@darranl
Copy link
Contributor

darranl commented May 25, 2023

Please don't make any further changes to this PR - I am going to combine it with a couple of other PRs so we can get them merged together.

Thank you for this implementation.

@darranl darranl added the ready-for-merge This PR is ready to be merged and fulfills all requirements label May 25, 2023
@darranl darranl merged commit 6ea1459 into wildfly:main May 26, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
21.0.0.Beta1 deps-ok Dependencies have been checked, and there are no significant changes ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
4 participants