[WFCORE-6345] Add missing JavaDoc and ensure the --yaml argument is a… #5495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dded at most once. Also added additional method for adding YAML configuration files. https://issues.redhat.com/browse/WFCORE-6345 Signed-off-by: James R. Perkins <jperkins@redhat.com>
github-actions
bot
added
the
deps-ok
yersan
approved these changes
May 9, 2023
| return this; | ||
| } | ||
| StringJoiner joiner = new StringJoiner(File.pathSeparator); | ||
| for (Path yamlFile : yamlFiles) { | ||
| joiner.add(yamlFile.toAbsolutePath().toString()); | ||
| } | ||
| addServerArg("--yaml", joiner.toString()); | ||
| setSingleServerArg("--yaml", joiner.toString()); |
There was a problem hiding this comment.
As a suggestion: addServerArg and setSingleServerArg do exactly the same; I'm not sure about the intention behind but probably we can remove one, they are package protected so, so the removal could be simple.
There was a problem hiding this comment.
The addServerArg() should add arguments to the command line, e.g. addServerArg("-yaml", "config-a.yml") and addServerArg("-yaml", "config-b.yml") should result in --yaml confiig-a.yml --yaml config-b.yml. Where as serSingleServerArg() should first remove an argument, then add it.
bstansberry
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dded at most once. Also added additional method for adding YAML configuration files.
https://issues.redhat.com/browse/WFCORE-6345