WFCORE-6369 Eliminate unnecessary collection copying in AbstractAddStepHandler constructors #5535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
deps-ok
bstansberry
reviewed
Jun 22, 2023
controller/src/main/java/org/jboss/as/controller/AbstractAddStepHandler.java
Outdated
Show resolved
Hide resolved
…epHandler constructor
Collect into list rather than set for heap efficiency, and because AttributeDefinition does not implement hashCode/equals.
yersan
approved these changes
Jun 30, 2023
There was a problem hiding this comment.
LGTM, @bstansberry you already did a review, anything else from your side?
bstansberry
approved these changes
Jun 30, 2023
There was a problem hiding this comment.
This approach changes the semantics of the protected 'attributes' field by making it immutable, but that's fine with me; as I'd have been ok with making it private.
We should follow this up by deprecating the field an adding a 'protected final Collection getAttributes()' javadoced as returning an immutable collection. But that doesn't need to block merging this.
yersan
added
the
ready-for-merge
|
I created https://issues.redhat.com/browse/WFCORE-6419 to follow up on the last comment |
|
Thanks @pferraro / @bstansberry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFCORE-6369
Fix improper use of Set in AbstractAddStepHandler.Parameters, since AttributeDefinition is not hashable.