Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFCORE-6305] Upgrade to Jandex 3.1.1 #5565

Merged
merged 1 commit into from
Jun 27, 2023
Merged

[WFCORE-6305] Upgrade to Jandex 3.1.1 #5565

merged 1 commit into from
Jun 27, 2023

Conversation

yersan
Copy link
Collaborator

@yersan yersan commented Jun 26, 2023

@yersan yersan requested a review from scottmarlow June 26, 2023 12:36
@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Jun 26, 2023
@scottmarlow
Copy link
Contributor

CC @franz1981 @beikov @Ladicek

Will Weld 5.1.1.Final + Hibernate ORM 6.2.5.Final work well with this upgrade to Jandex 3.1.1 which I requested?

Note that hibernate/hibernate-orm#6402 is still pending which would reduce memory allocation especially with this upgrade.

@Ladicek
Copy link
Contributor

Ladicek commented Jun 26, 2023 •
edited

I'd recommend using 3.1.2 which has some fixes for newer JDKs: https://smallrye.io/blog/jandex-3-1-2/

That said, I'm not aware of any breaking changes between 3.0 and 3.1, so things should just work.

@wildfly-ci
Copy link

Core -> Full Integration Build 12514 outcome was FAILURE using a merge of cbf6d0c
Summary: Tests failed: 1 (1 new), passed: 4100, ignored: 58 Build time: 01:56:09

Failed tests

org.jboss.as.test.integration.jpa.webtxem.WebJPATestCase.testReadWrite: java.io.IOException: java.util.concurrent.ExecutionException: java.io.IOException: HTTP Status 500 Response: <html><head><title>ERROR</title><style>
body {
    font-family: "Lucida Grande", "Lucida Sans Unicode", "Trebuchet MS", Helvetica, Arial, Verdana, sans-serif;
    margin: 5px;
}

.header {
    background-image: linear-gradient(bottom, rgb(153,151,153) 8%, rgb(199,199,199) 54%);
    background-image: -o-linear-gradient(bottom, rgb(153,151,153) 8%, rgb(199,199,199) 54%);
    background-image: -moz-linear-gradient(bottom, rgb(153,151,153) 8%, rgb(199,199,199) 54%);
    background-image: -webkit-linear-gradient(bottom, rgb(153,151,153) 8%, rgb(199,199,199) 54%);
    background-image: -ms-linear-gradient(bottom, rgb(153,151,153) 8%, rgb(199,199,199) 54%);
    
    background-image: -webkit-gradient(
        linear,
        left bottom,
        left top,
        color-stop(0.08, rgb(153,151,153)),
        color-stop(0.54, rgb(199,199,199))
    );
    color: black;
    padding: 2px;
    font-weight: normal;
    border: solid 1px;
    font-size: 170%;
    text-align: left;
    vertical-align: middle; 
    height: 32px; 
    margin-bottom: 10px;
}
.error-div {
    display: inline-block;
    width: 32px;
    height: 32px;
    background: url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAABmJLR0QAAAAAAAD5Q7t/AAAACXBIWXMAAABIAAAASABGyWs+AAAACXZwQWcAAAAgAAAAIACH+pydAAAGGElEQVRYw8WXW2wcVxnHf+fM7NXrdXbdtZ3ipGqCEzvQKmlFoUggwkvvGBoaqVVV5Y0nkCoQPPCAhMQbQlzUh/IWHoh6QUVKZVLxUCGogKZRW9uJkyg0iVzZ2dhre9c7u7M7c87hYWc2M7t2bBASI306O/85+v7/7zLn24H/8yV2u/EcFNvwVNK2X0DKw1qpYaX1gCWlY0m5arRe8JQ6I2DmaVj/nwk4CxO2Zf1aw9dKo6N67+eOZHN7x0gViiSHBmlXa7hrazjLt1i+eKmxUi5bwpg/e8a8PA3X/msBr0MyJ+WvgFOffehY8v7HH5OW78HqGjgOtNrge2AnIJWAgQEYLqBsm3/NvKM/mZ1rYczpRa2/9x3w/iMBM1BCiHfuGRmZevClF9NJ5cP1m9B0+/aa3t/ZDNw3TtuSfPy737trK6sXtTGPPwOruxLwNhSEEHMHpqZGDz93wubKFdio3ZXUGNOHs2cIDh/g6pt/9G8uXLnlGPP5k1Dt5bN60m6lhXj34OTkxKET37SZm4d6oz/KgFRH7yOrBozbwlTWGf7ql6RZrWTcytrxaTj9Ro9OGb3JS/mz0nDxgYnnvmWbuUsdJ6FTY2JmImShqZA83N90UbOXOXDiG4nCcPFoTsqfbluCP8DenJQLx1/+7pBcXILaZl9qo2svFmalb48xkM9hxkf5+29+u9HSenIayn0ZyEr5i0NHpnKy7aGrtW6UehsLozRBRlRQEh3BwzLpWh3h++yfPJRLSvnzvhK8DkPamOl7n3nCUjcXtyXuK0X0WViaAFc9QtSNJe594uu2MubZGcjHBGTgqeFiQQml0K12nDgSpd4iyi4uRMci6Q8xJSWq7SGEZCg/qD14LCYgIcTzoxMHc6qygYk40aETKTFSdh2aANOWhbEsjJSYCK6C/V0LcH+9xvCB/TlbiBdCAXbQMJPZ/fvQjUbXEULAa6/1deyuh0dwNU+e7DSzEOhmi8xn9iI+ujgVE6ChlBwpYcqVjuIgA3IXBMYYtNbd30IIpJQI0ZEa+gPQnk9ieA8GSrESaGNyiWIBrVQntUHqdrq01iiluo0WilBK4fs+WutOr4S9YAyJoRzamMGYAClEve046ETyTr13EKCU6kZ+N4GNCxfwKpVOryQSuOUVhBCbsRIIuN1cWRkaSCfRrdaOTncijgltNPDn5xHZLIn7x3GNh4CVmADgcv3a9YmBY0cxm06nAQH31KlOao3BL5fxbtzAOE73hAt7JXb6RU7PGO44WK5Do1ZHw6WYAN+YM+X5S8dLXziWizVNvY5aWcFfWuq8Idsctb1Yr8DwmRwrUr1yfVMbcyYmwIWZ2mbdai9+gvfBAsaAbrUwrrtllLuJPibIGGQ2hUlIHLdlA+diTXgSqkKIt5b/OevL+8bwqlWU63anW3jyhaa4c9T2Hs0hrsL5EOCJQ/sov7/gS8Mb07AZEwDgav2D5aVy3eSziEL+Dllk0PSRcmcMqx6BUeGykINsksrttboPP4w2aVfACVhGiFevvft+I/XwJCad3DF6tc2MiD4zmRSZhyZY/OusI4V4JTqKYwIA6lr/2Gm6s5/+7UMv/egDmEyqL7VbRR/LViR6sikGvniYpffm2m6r/VFd65/0vqZ9R/tbsMeG+WKpMDL+lWMJ58Jl/NVqvOG26PAoDmCXhhg4epDl9+a9zUp1uQkPbvWfcMvZchbuEXAuk0kf2X/84YxpuDQv3kA5zW1fw9CswSyZyXFEJsmnf/m46bntuTY8+SxUtuLadri9CokxeEUK8WJhtJgaeeSIxG3RurWGv+Gg3RbaU5CwkOkU1lCWxFgBmbS4ff6qX7297rXh9Gn4/llobMcjtsFywACQ+zZMTsOP8vBIOpNS+bFiJj2cxx7MYg+k8ZwmrWqD9lqNjVvrTc9tWRtw/k345dtwFagDTmTdUUA2EDAYXffB2JPw6FH4ch7GUpCzIemD50J9A1Y+hH/8Cc4vdTq9Tud9D9dNOt+MajclyNL53xZmIhusmcBSQJLOd4UJnHqACzTppDy0kHizl/yuPRB5nggIM0A6IE4GuA34EQFtoBUQuwGm7kbwb+eaEEXmuV5dAAAAJXRFWHRjcmVhdGUtZGF0ZQAyMDA5LTExLTEwVDE5OjM4OjI0LTA3OjAwdDKp4gAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAxMC0wMi0yMFQyMzoyNjoyNC0wNzowMC7DUNYAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMTAtMDEtMTFUMDg6NTc6MzUtMDc6MDCruapPAAAAMnRFWHRMaWNlbnNlAGh0dHA6Ly9lbi53aWtpcGVkaWEub3JnL3dpa2kvUHVibGljX2RvbWFpbj/96s8AAAAldEVYdG1vZGlmeS1kYXRlADIwMDktMTEtMTBUMTk6Mzg6MjQtMDc6MDArg9/WAAAAGXRFWHRTb3VyY2UAVGFuZ28gSWNvbiBMaWJyYXJ5VM/tggAAADp0RVh0U291cmNlX1VSTABodHRwOi8vdGFuZ28uZnJlZWRlc2t0b3Aub3JnL1RhbmdvX0ljb25fTGlicmFyebzIrdYAAAAASUVORK5CYII=') left center no-repeat;
}
.error-text-div {
    display: inline-block;
    vertical-align: top;
    height: 32px;
}
.label {
    font-weight:bold;
    display: inline-block;
}
.value {
    display: inline-block;
    margin-left: 5px;
}
pre {
    font-size: 110%;

@scottmarlow
Copy link
Contributor

The test failure appears to be caused by a setup failure creating table WebTxEmFlight:

Caused by: org.h2.jdbc.JdbcSQLNonTransientException: GeneralError; SQL statement:
create table WebTxEmFlight (comp_id bigint, flight_id bigint generated by default as identity, flight_name varchar(50) not null, primary key (flight_id)) [50000-214]
  at com.h2database.h2@2.1.214//org.h2.message.DbException.getJdbcSQLException(DbException.java:554)
  at com.h2database.h2@2.1.214//org.h2.message.DbException.addSQL(DbException.java:177)
  at com.h2database.h2@2.1.214//org.h2.command.Command.executeUpdate(Command.java:268)
  at com.h2database.h2@2.1.214//org.h2.jdbc.JdbcStatement.executeInternal(JdbcStatement.java:252)
  at com.h2database.h2@2.1.214//org.h2.jdbc.JdbcStatement.execute(JdbcStatement.java:223)
  at org.jboss.ironjacamar.jdbcadapters@3.0.2.Final//org.jboss.jca.adapters.jdbc.WrappedStatement.execute(WrappedStatement.java:198)
  at org.hibernate@6.2.5.Final//org.hibernate.tool.schema.internal.exec.GenerationTargetToDatabase.accept(GenerationTargetToDatabase.java:78)
  ... 29 more
Caused by: java.sql.SQLException: GeneralError
  at com.h2database.h2@2.1.214//org.h2.message.DbException.convert(DbException.java:400)
  at com.h2database.h2@2.1.214//org.h2.command.Command.executeUpdate(Command.java:264)
  ... 33 more
Caused by: java.lang.AssertionError
  at com.h2database.h2@2.1.214//org.h2.engine.Database.addMeta(Database.java:731)
  at com.h2database.h2@2.1.214//org.h2.engine.Database.addSchemaObject(Database.java:909)
  at com.h2database.h2@2.1.214//org.h2.table.Column.initializeSequence(Column.java:461)
  at com.h2database.h2@2.1.214//org.h2.command.ddl.CommandWithColumns.generateSequences(CommandWithColumns.java:103)
  at com.h2database.h2@2.1.214//org.h2.command.ddl.CreateTable.update(CreateTable.java:113)
  at com.h2database.h2@2.1.214//org.h2.command.CommandContainer.update(CommandContainer.java:169)
  at com.h2database.h2@2.1.214//org.h2.command.Command.executeUpdate(Command.java:252)

@bstansberry
Copy link
Contributor

@scottmarlow I'm going to assume that failure means wildfly/wildfly#16846 did not resolve the longstanding intermittent failure problem with that test. It passed with this PR on a subsequent run.

@bstansberry bstansberry merged commit 4c1dbf7 into wildfly:main Jun 27, 2023
12 checks passed
@bstansberry
Copy link
Contributor

Thanks @yersan, @scottmarlow and @Ladicek. I'll send up a separate PR to go to 3.1.2.

@bstansberry
Copy link
Contributor

The separate PR: #5568

@yersan yersan deleted the WFCORE-6305 branch June 28, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottmarlow scottmarlow Awaiting requested review from scottmarlow

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
Milestone
No milestone
5 participants
@yersan @scottmarlow @Ladicek @wildfly-ci @bstansberry