[WFCORE-6524] Do not duplicate managed deployment in content repository in tmp/vfs/temp directory #5689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
deps-ok
gaol
force-pushed
the
WFCORE-6524
branch
2 times, most recently
from
0952ae5
to
d9bd192
Compare
yersan
reviewed
Sep 27, 2023
Comment on lines
1
to
4
| /* | ||
| * JBoss, Home of Professional Open Source. | ||
| * Copyright 2023 Red Hat, Inc., and individual contributors | ||
| * as indicated by the @author tags. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ |
There was a problem hiding this comment.
Hi @gaol, the license header formats have changed since 22.0.0.Beta3, could you replace this by:
/*
* Copyright The WildFly Authors
* SPDX-License-Identifier: Apache-2.0
*/
ehsavoie
approved these changes
Sep 28, 2023
|
@gaol FYI, I haven't looked at the reasons yet, but WildFly full PR fails with this one in place, look at the Linux Job, the one for Windows need more CI tweak. |
…ry in tmp/vfs/temp directory
|
@yersan done, hope it will work. I will be on holidays and PTO in the coming 2 weeks, I will back to this if there is other issue to fix :) |
|
oohh, my fault with the Jobs configuration, I'll kick them off again. Enjoy your well-deserved PTOs. |
yersan
approved these changes
Oct 3, 2023
yersan
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/WFCORE-6524