Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFCORE-6590] Upgrade commons-lang3 from 3.12.0 to 3.13.0 #5755

Merged
merged 1 commit into from Nov 9, 2023
Merged

[WFCORE-6590] Upgrade commons-lang3 from 3.12.0 to 3.13.0 #5755

merged 1 commit into from Nov 9, 2023

Conversation

yersan
Copy link
Collaborator

@yersan yersan commented Nov 7, 2023

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Nov 7, 2023
fjuma
fjuma approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yersan!

@yersan
Copy link
Collaborator Author

yersan commented Nov 8, 2023 •
edited

In WildFly full, this dependency is generally used as a test dependency. The only one I've found could be affected (in addition to the test cases) is org.apache.activemq:artemis-server. However, tests are green, so looks we are good to move on.

[INFO] +- org.apache.activemq:artemis-server:jar:2.31.2:compile
[INFO] |  +- com.github.ben-manes.caffeine:caffeine:jar:3.1.8:compile
[INFO] |  +- org.apache.activemq:artemis-selector:jar:2.31.2:compile
[INFO] |  +- org.apache.activemq:artemis-jdbc-store:jar:2.31.2:compile
[INFO] |  +- org.apache.activemq:artemis-quorum-api:jar:2.31.2:compile
[INFO] |  +- io.netty:netty-transport-classes-epoll:jar:4.1.100.Final:compile
[INFO] |  +- io.netty:netty-transport-classes-kqueue:jar:4.1.100.Final:compile
[INFO] |  +- commons-beanutils:commons-beanutils:jar:1.9.4:compile
[INFO] |  +- org.apache.commons:commons-lang3:jar:3.12.0:compile
[INFO] |  \- commons-collections:commons-collections:jar:3.2.2:compile

@ehsavoie FYI, in case you are opposed to this upgrade. I'll wait one day more before moving on.

@yersan yersan added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Nov 9, 2023
@yersan yersan merged commit 89b7672 into wildfly:main Nov 9, 2023
12 checks passed
@yersan yersan deleted the WFCORE-6590 branch November 9, 2023 09:43
@yersan
Copy link
Collaborator Author

yersan commented Nov 9, 2023

Thank you @fjuma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjuma fjuma fjuma approved these changes

@bstansberry bstansberry Awaiting requested review from bstansberry

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Milestone
No milestone
2 participants
@yersan @fjuma