Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-6627] Make use of the SetRequestInformationMechanismFactory to set the request information during HTTP authentication #5779

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

Skyllarr
Copy link
Contributor

@Skyllarr Skyllarr commented Nov 27, 2023

https://issues.redhat.com/browse/WFCORE-6627

Requires: ELY-2583 : wildfly-security/wildfly-elytron#1952
so requires Elytron 2.2.3.Final component upgrade: #5835

@wildfly-ci
Copy link

Core -> Full Integration Build 13256 outcome was FAILURE using a merge of e35666d
Summary: Compilation error: Compiler (new) Build time: 00:01:06

@wildfly-ci
Copy link

Core -> WildFly Preview Integration Build 13101 outcome was FAILURE using a merge of e35666d
Summary: Compilation error: Compiler (new) Build time: 00:01:11

@wildfly-ci
Copy link

Core -> Full Integration Build 13032 outcome was FAILURE using a merge of e35666d
Summary: Compilation error: Compiler (new) Build time: 00:01:12

@bstansberry
Copy link
Contributor

@Skyllarr There's a compile problem:

[20:22:18][Step 3/6] [ERROR] /opt/buildAgent/work/e8e0dd9c7c4ba60/core/elytron/src/main/java/org/wildfly/extension/elytron/HttpServerDefinitions.java:[60,38] cannot find symbol
[20:22:18][Step 3/6] [ERROR]   symbol:   class SetRequestInformationCallbackMechanismFactory
[20:22:18][Step 3/6] [ERROR]   location: package org.wildfly.security.http.util

@wildfly-ci
Copy link

Core -> WildFly Preview Integration Build 13109 outcome was FAILURE using a merge of 612607b
Summary: Compilation error: Compiler (new) Build time: 00:01:12

@wildfly-ci
Copy link

Core -> Full Integration Build 13264 outcome was FAILURE using a merge of 612607b
Summary: Compilation error: Compiler (new) Build time: 00:01:22

@wildfly-ci
Copy link

Core -> Full Integration Build 13039 outcome was FAILURE using a merge of 612607b
Summary: Compilation error: Compiler (new) Build time: 00:01:35

@Skyllarr
Copy link
Contributor Author

@Skyllarr There's a compile problem:

[20:22:18][Step 3/6] [ERROR] /opt/buildAgent/work/e8e0dd9c7c4ba60/core/elytron/src/main/java/org/wildfly/extension/elytron/HttpServerDefinitions.java:[60,38] cannot find symbol
[20:22:18][Step 3/6] [ERROR]   symbol:   class SetRequestInformationCallbackMechanismFactory
[20:22:18][Step 3/6] [ERROR]   location: package org.wildfly.security.http.util

@bstansberry this requires wildfly-elytron change, sorry I did not add this to the PR description before, fixed now

@bstansberry
Copy link
Contributor

bstansberry commented Nov 28, 2023

No problem, @Skyllarr.

Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Skyllarr!

…o set the request information during HTTP authentication
@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Jan 17, 2024
@yersan yersan added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Jan 18, 2024
@yersan yersan merged commit 8464473 into wildfly:main Jan 18, 2024
12 checks passed
@yersan
Copy link
Collaborator

yersan commented Jan 18, 2024

Thanks @Skyllarr and all the ones involved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
6 participants