[WFCORE-6658] Convert ControlledProcessStateService to the current MS… #5824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ropalka FYI. |
github-actions
bot
added
the
deps-ok
bstansberry
force-pushed
the
WFCORE-6658
branch
from
bb841d0
to
658f5f3
Compare
bstansberry
force-pushed
the
WFCORE-6658
branch
from
658f5f3
to
1d3bd88
Compare
bstansberry
added
hold
yersan
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
LGTM, @ropalka could you also take a quick look?
My very minor detail is that now the new SimpleService that provides the ProcessStateNotifier is not invoking consumer.accept(null) on the stop method as we did in ControlledProcessStateService:61, I don't think it could be an issue, but I am not certainly sure if that could cause any unexpected side effect. It is done when the service is being stopped, so it looks like safe.
| @@ -221,6 +230,7 @@ private synchronized void establishModelControllerClient(ControlledProcessState. | |||
| if (state != ControlledProcessState.State.STOPPING && state != ControlledProcessState.State.STOPPED && serviceContainer != null) { | |||
| ModelControllerClientFactory clientFactory; | |||
| try { | |||
| // TODO replace this in start() with the ServiceActivator approach we used to capture the ProcessStateNotifier | |||
There was a problem hiding this comment.
I've just added WFCORE-6662 as a follow up to cover this.
|
@ropalka FYI in case you have missed it. |
yersan
added
the
ready-for-merge
|
Thanks @bstansberry and @ropalka |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…C API
https://issues.redhat.com/browse/WFCORE-6658