WFCORE-6697: fix resource location check #5869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
deps-ok
yersan
reviewed
Feb 19, 2024
| @@ -211,7 +211,7 @@ private static List<String> findResourcePaths(String moduleName) throws ModuleLo | |||
|
|
|||
| List<String> result = new LinkedList<>(); | |||
| for (ResourceLoaderInfo rl : loader.getResourceLoaders(moduleName)){ | |||
| if (rl.getLocation() != null) { | |||
| if (!rl.getLocation().equals("null")) { | |||
There was a problem hiding this comment.
The ResourceLoaderInfo constructor and getLocation() method don't say too much about the nullity returned in case there is no location, but in any case, checking for a null value before comparing with "null" string would make it more resilient to JBoss Modules changes.
What do you think @michpetrov ?
There was a problem hiding this comment.
The initialization was changed to avoid dealing with null values - jboss-modules/jboss-modules@a357326 - so I don't think it's likely, but sure I'll change it.
michpetrov
force-pushed
the
wfcore-6697
branch
from
08ec940
to
51f2ddc
Compare
yersan
approved these changes
Feb 21, 2024
yersan
added
the
ready-for-merge
|
Thanks @michpetrov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: WFCORE-6697
The operation is deprecated so I don't know if we want to fix this.