WFCORE-4868: implement aliases for standalone configuration files #5903

michpetrov · 2024-03-15T19:30:34Z

Issue: WFCORE-4868

Documentation PR: wildfly/wildfly#17751

server/src/main/java/org/jboss/as/server/ServerEnvironment.java

host-controller/src/main/java/org/jboss/as/host/controller/HostControllerEnvironment.java

...troller/src/main/java/org/jboss/as/host/controller/HostControllerConfigurationPersister.java

controller/src/main/java/org/jboss/as/controller/persistence/ConfigurationFile.java

yersan

This RFE also needs the community documentation PR linked and ready

server/src/test/java/org/jboss/as/server/ServerEnvironmentTestCase.java

yersan

LGTM, we still need the documentation PR linked and full approval of the proposal by all the parties, but the changes here look good to me, thanks @michpetrov !

yersan · 2024-03-22T17:51:06Z

@darranl FYI proposal has been approved by all the parties, so I would say this is ready to go in, just need the documentation PR

michpetrov · 2024-03-22T18:45:06Z

@yersan the PR is linked in the top comment

wildfly-ci · 2024-03-22T21:06:50Z

Core -> Full Integration Build 13651 outcome was FAILURE using a merge of 2ba2d9a
Summary: Tests failed: 1 (1 new), passed: 7591, ignored: 131 Build time: 04:06:43

Failed tests

TestSuite: org.eclipse.microprofile.fault.tolerance.tck.disableEnv.DisableFTEnableOnMethodTest.testTimeout: java.lang.AssertionError: Expected TimeoutException to be thrown, but TestException was thrown
	at deployment.ftDisableGloballyEnableMethod.war//org.testng.Assert.expectThrows(Assert.java:1724)
	at deployment.ftDisableGloballyEnableMethod.war//org.testng.Assert.assertThrows(Assert.java:1695)
	at deployment.ftDisableGloballyEnableMethod.war//org.eclipse.microprofile.fault.tolerance.tck.disableEnv.DisableFTEnableOnMethodTest.testTimeout(DisableFTEnableOnMethodTest.java:116)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at deployment.ftDisableGloballyEnableMethod.war//org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:133)
	at deployment.ftDisableGloballyEnableMethod.war//org.testng.internal.MethodInvocationHelper$1.runTestMethod(MethodInvocationHelper.java:239)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor185.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor184.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at deployment.ftDisableGloballyEnableMethod.war//org.testng.internal.MethodInvocationHelper.invokeHookable(MethodInvocationHelper.java:253)
	at deployment.ftDisableGloballyEnableMethod.war//org.testng.internal.TestInvoker.invokeMethod(TestInvoker.java:594)
	at deployment.ftDisableGloballyEnableMethod.war//org.testng.internal.TestInvoker.invokeTestMethod(TestInvoker.java:173)
	at deployment.ftDisableGloballyEnableMethod.war//org.testng.internal.MethodRunner.runInSequence(MethodRunner.java:46)
	at deployment.ftDisableGloballyEnableMethod.war//org.testng.internal.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:824)
	at deployment.ftDisableGloballyEnableMethod.war//org.testng.internal.TestInvoker.invokeTestMethods(TestInvoker.java:146)
	at deployment.ftDisableGloballyEnableMethod.war//org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146)
	at deployment.ftDisableGloballyEnableMethod.war//org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:128)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
	at deployment.ftDisableGloballyEnableMethod.war//org.testng.TestRunner.privateRun(TestRunner.java:794)
	at deployment.ftDisableGloballyEnableMethod.war//org.testng.TestRunner.run(TestRunner.java:596)
	at deployment.ftDisableGloballyEnableMethod.war//org.testng.SuiteRunner.runTest(SuiteRunner.java:377)
	at deployment.ftDisableGloballyEnableMethod.war//org.testng.SuiteRunner.runSequentially(SuiteRunner.java:371)
	at deployment.ftDisableGloballyEnableMethod.war//org.testng.SuiteRunner.privateRun(SuiteRunner.java:332)
	at deployment.ftDisableGloballyEnableMethod.war//org.testng.SuiteRunner.run(SuiteRunner.java:276)
	at deployment.ftDisableGloballyEnableMethod.war//org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53)
	at deployment.ftDisableGloballyEnableMethod.war//org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:96)
	at deployment.ftDisableGloballyEnableMethod.war//org.testng.TestNG.runSuitesSequentially(TestNG.java:1212)
	at deployment.ftDisableGloballyEnableMethod.war//org.testng.TestNG.runSuitesLocally(TestNG.java:1134)
	at deployment.ftDisableGloballyEnableMethod.war//org.testng.TestNG.runSuites(TestNG.java:1063)
	at deployment.ftDisableGloballyEnableMethod.war//org.testng.TestNG.run(TestNG.java:1031)
	at jakarta.servlet.api@6.0.0//jakarta.servlet.http.HttpServlet.service(HttpServlet.java:527)
	at jakarta.servlet.api@6.0.0//jakarta.servlet.http.HttpServlet.service(HttpServlet.java:614)
	at io.undertow.servlet@2.3.12.Final//io.undertow.servlet.handlers.ServletHandler.handleRequest(ServletHandler.java:74)
	at io.undertow.servlet@2.3.12.Final//io.undertow.servlet.handlers.security.ServletSecurityRoleHandler.handleRequest(ServletSecurityRoleHandler.java:62)
	at io.undertow.servlet@2.3.12.Final//io.undertow.servlet.handlers.ServletChain$1.handleRequest(ServletChain.java:68)
	at io.undertow.servlet@2.3.12.Final//io.undertow.servlet.handlers.ServletDispatchingHandler.handleRequest(ServletDispatchingHandler.java:36)
	at org.wildfly.security.elytron-web.undertow-server@4.1.0.Final//org.wildfly.elytron.web.undertow.server.ElytronRunAsHandler.lambda$handleRequest$1(ElytronRunAsHandler.java:68)
	at org.wildfly.security.elytron-base@2.3.1.Final//org.wildfly.security.auth.server.FlexibleIdentityAssociation.runAsFunctionEx(FlexibleIdentityAssociation.java:103)

darranl · 2024-03-25T10:15:22Z

I have just kicked off the CI jib that had an error again, looks like I can proceed with the merge once this completes.

darranl · 2024-03-25T14:54:33Z

Thank you @michpetrov

github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Mar 15, 2024

yersan requested changes Mar 18, 2024

View reviewed changes

yersan reviewed Mar 18, 2024

View reviewed changes

controller/src/main/java/org/jboss/as/controller/persistence/ConfigurationFile.java Outdated Show resolved Hide resolved

yersan requested changes Mar 20, 2024

View reviewed changes

yersan mentioned this pull request Mar 22, 2024

WFCORE-4868 Introduce aliases for standard configuration files wildfly/wildfly-proposals#390

Merged

michpetrov force-pushed the wfcore-4868 branch from c9d07f4 to d745cd9 Compare March 22, 2024 13:58

yersan reviewed Mar 22, 2024

View reviewed changes

server/src/test/java/org/jboss/as/server/ServerEnvironmentTestCase.java Outdated Show resolved Hide resolved

WFCORE-4868: implement aliases for standalone configuration files

2ba2d9a

michpetrov force-pushed the wfcore-4868 branch from d745cd9 to 2ba2d9a Compare March 22, 2024 16:56

yersan approved these changes Mar 22, 2024

View reviewed changes

darranl mentioned this pull request Mar 25, 2024

Aggregate PR #5918

Closed

darranl merged commit bca245b into wildfly:main Mar 25, 2024
12 checks passed

michpetrov deleted the wfcore-4868 branch April 9, 2024 12:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WFCORE-4868: implement aliases for standalone configuration files #5903

WFCORE-4868: implement aliases for standalone configuration files #5903

michpetrov commented Mar 15, 2024 •

edited

yersan left a comment

yersan left a comment •

edited

yersan commented Mar 22, 2024

michpetrov commented Mar 22, 2024

wildfly-ci commented Mar 22, 2024

darranl commented Mar 25, 2024

darranl commented Mar 25, 2024

WFCORE-4868: implement aliases for standalone configuration files #5903

WFCORE-4868: implement aliases for standalone configuration files #5903

Conversation

michpetrov commented Mar 15, 2024 • edited

yersan left a comment

Choose a reason for hiding this comment

yersan left a comment • edited

Choose a reason for hiding this comment

yersan commented Mar 22, 2024

michpetrov commented Mar 22, 2024

wildfly-ci commented Mar 22, 2024

Failed tests

darranl commented Mar 25, 2024

darranl commented Mar 25, 2024

michpetrov commented Mar 15, 2024 •

edited

yersan left a comment •

edited