New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFCORE-460 Enhanced syntax support #621
Conversation
Windows Build 1182 is now running using a merge of e25e90a |
Linux Build 1528 is now running using a merge of e25e90a |
Linux Build 1528 outcome was SUCCESS using a merge of e25e90a |
Windows Build 1182 outcome was SUCCESS using a merge of e25e90a |
Windows Build 1186 is now running using a merge of 3214fa8 |
Linux Build 1532 is now running using a merge of 3214fa8 |
Linux Build 1532 outcome was SUCCESS using a merge of 3214fa8 |
Windows Build 1186 outcome was SUCCESS using a merge of 3214fa8 |
} | ||
result.set(newValue); | ||
return oldValue; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method's whitespace is messed up.
In general, it's looking good. I'm too lazy to examine the tests in detail. :) Is there any coverage of a rollback of an enhanced syntax write-attribute? That's one case I could imagine getting messed up. |
Linux Build 1538 is now running using a merge of 781dcd9 |
Windows Build 1192 is now running using a merge of 781dcd9 |
Linux Build 1538 outcome was FAILURE using a merge of 781dcd9 Build problems:Process exited with code 1 |
Windows Build 1193 is now running using a merge of e8630b8 |
Linux Build 1541 is now running using a merge of 50d2154 |
Windows Build 1196 is now running using a merge of 50d2154 |
Linux Build 1541 outcome was SUCCESS using a merge of 50d2154 |
Windows Build 1196 outcome was SUCCESS using a merge of 50d2154 |
…ler, AttributeAccess.Storage)
Linux Build 1554 is now running using a merge of df8de4f |
Windows Build 1207 is now running using a merge of df8de4f |
Linux Build 1554 outcome was SUCCESS using a merge of df8de4f |
Windows Build 1207 outcome was SUCCESS using a merge of df8de4f |
Linux Build 1556 is now running using a merge of f65bfc8 |
Windows Build 1209 is now running using a merge of f65bfc8 |
Linux Build 1556 outcome was SUCCESS using a merge of f65bfc8 |
Windows Build 1209 outcome was SUCCESS using a merge of f65bfc8 |
[WFCORE-460 Enhanced syntax support
https://issues.jboss.org/browse/WFCORE-460