Support --debug flag without port argument #629
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a dummy positional parameter in the instance where --debug is specified but no port is provided. This dummy parameter will be swallowed instead of the next true parameter.
|
Can one of the admins verify this patch? |
|
this is ok to test |
|
Windows Build 1201 is now running using a merge of 40941ba |
|
Linux Build 1547 is now running using a merge of 40941ba |
|
Linux Build 1547 outcome was SUCCESS using a merge of 40941ba |
|
Windows Build 1201 outcome was SUCCESS using a merge of 40941ba |
|
Which OS seems to have this issue? |
|
FWIW this looks like it would fix the issue as well #638. |
|
Yes, this is fixed by #638. Closing this PR. |
|
Excellent, thank you! |
dcihak
pushed a commit
to dcihak/wildfly-core
that referenced
this pull request
Dec 12, 2018
[JBEAP-15852] Upgrade WildFly Common to 1.2.1.Final
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a dummy positional parameter in the instance where --debug is
specified but no port is provided. This dummy parameter will be
swallowed instead of the next true parameter.