[WFLY-1877]: Make KeepAliveTimeAttributeDefinition deal with both a simple long and a complex attribute. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ; | ||
|
|
||
| /** | ||
| * The current namespace version. | ||
| */ | ||
| public static final Namespace CURRENT = THREADS_1_1; | ||
| public static final Namespace CURRENT = THREADS_1_2; |
| @@ -125,4 +142,56 @@ public void parseAndSetParameter(final ModelNode operation, final XMLExtendedStr | |||
|
|
|||
| operation.get(getName()).set(model); | |||
| } | |||
|
|
|||
| private static class UnitConvertor implements ParameterValidator { | |||
There was a problem hiding this comment.
The org.jboss.as.controller.ParameterCorrector interface is more appropriate for this kind of thing. It can be added to an AttributeDefinition via the setCorrector method on the builder.
There was a problem hiding this comment.
So I'll have to update also he PR for WFLY-1878 which is kind of similar.
…imple long and a complex attribute. Transforming KeepAliveTimeAttributeDefinition in Model from a complex Object to a Long. All keep-alive now are expressed as long in milliseconds. This will affects all subsystems using the "threads" subsystem.
|
Replaced by #189 |
dehort
pushed a commit
to dehort/wildfly-core
that referenced
this pull request
Dec 11, 2015
Prod rebuilds
dmlloyd
added a commit
to dmlloyd/wildfly-core
that referenced
this pull request
Mar 10, 2017
Use OptionalNameCallback to know when login name is not mandatory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transforming KeepAliveTimeAttributeDefinition in Model from a complex Object to a Long.
All keep-alive now are expressed as long in milliseconds.
This will affects all subsystems using the "threads" subsystem.
Core Jira: https://issues.jboss.org/browse/WFCORE-39
WildFly Jira: https://issues.jboss.org/browse/WFLY-1877