[WFCORE-114] : Get RuntimeVaultReader into WildFly Core #679
Conversation
|
Linux Build 1760 is now running using a merge of 3800699 |
|
Windows Build 1322 is now running using a merge of 3800699 |
|
Windows Build 1322 outcome was SUCCESS using a merge of 3800699 |
|
Linux Build 1760 outcome was SUCCESS using a merge of 3800699 |
|
Core - Full Integration Build 914 outcome was FAILURE using a merge of 3800699 Build problems:Failed tests detected Failed tests |
|
This doesn't really help, as this class is loaded via ServiceLoader and there's no hook for that. So a user couldn't add support simply by installing the picketbox module. |
Moving RuntimeVaultReader from WildFly to WildFly-Core
bstansberry
force-pushed
the
pullRequest620
branch
from
3800699
to
bfb894b
Compare
|
Windows Build 1344 is now running using a merge of bfb894b |
|
Linux Build 1784 is now running using a merge of bfb894b |
|
Windows Build 1344 outcome was SUCCESS using a merge of bfb894b |
|
Linux Build 1784 outcome was FAILURE using a merge of bfb894b Build problems:Execution timeout |
Deal with NCDFE that will happen if picketbox is not present Change the module.xml to not see the legacy server subsystem service loader class This will allow a WildFly Core based server to have vault support if picketbox is present
bstansberry
force-pushed
the
pullRequest620
branch
from
bfb894b
to
1a55006
Compare
|
Linux Build 1786 is now running using a merge of 1a55006 |
|
Windows Build 1345 is now running using a merge of 1a55006 |
|
Windows Build 1345 outcome was SUCCESS using a merge of 1a55006 |
|
Linux Build 1786 outcome was SUCCESS using a merge of 1a55006 |
bstansberry
added
the
ready-for-merge
[WFCORE-114] : Get RuntimeVaultReader into WildFly Core
Moving RuntimeVaultReader from WildFly to WildFly-Core
Reopening #620 as having this does good and doesn't mean the picketbox lib must be present in core.
Right now (w/o this PR) the way it works is the service loader is in org.jboss.as.security which is visible because HC and server module.xml optionally depend on org.jboss.as.security, with services=import.
With this PR the service loader is in server, which HC already depends on, but now I added services=import too. So the core modules no longer need to depend on org.jboss.as.security as they get nothing from it.
The vault doesn't actually work in core, because there is no picketbox module but server module has an optional dep on picketbox, so if it is present (i.e. in full) then it just works.
I will need to follow up with a PR for full to delete the old org.jboss.as.security RuntimeVaultReader and its service loader file but that's just a cleanup of cruft; it's dead code now because core modules no longer make that stuff visible.