Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] WFCORE-692 read-children-names(include-aliases=true) can return phantom results #729

Merged
merged 1 commit into from May 15, 2015

Conversation

pferraro
Copy link
Contributor

if another resource exists with the same key as tje target address of a resource alias.

https://issues.jboss.org/browse/WFCORE-692

@wildfly-ci
Copy link

Linux Build 30 is now running using a merge of 87048ba

@wildfly-ci
Copy link

Windows Build 26 is now running using a merge of 87048ba

@wildfly-ci
Copy link

Core - Full Integration Build 25 is now running using a merge of 87048ba

@wildfly-ci
Copy link

Windows Build 26 outcome was SUCCESS using a merge of 87048ba
Summary: Tests passed: 3103, ignored: 66 Build time: 0:20:31

@wildfly-ci
Copy link

Linux Build 30 outcome was SUCCESS using a merge of 87048ba
Summary: Tests passed: 3103, ignored: 66 Build time: 0:23:08

@wildfly-ci
Copy link

Core - Full Integration Build 25 outcome was FAILURE using a merge of 87048ba
Summary: Tests failed: 1 (1 new), passed: 2844, ignored: 375 Build time: 0:51:08

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.messaging.mgmt.JMSTopicManagementTestCase.removeJMSTopicRemovesAllMessages: <no details avaliable>

@bstansberry
Copy link
Contributor

Is this affecting you in 9.x? The method you are changing affects a lot of calls, so I'm reluctant to change it at the last minute in 9 to fix a problem that you don't see until 10.

That said, I think with the tweak I mention in my comment on the master PR, this looks pretty safe.

@pferraro
Copy link
Contributor Author

Technically, I don't need this until 10. I opened a PR against 1.x since I figured that 1.0.0.Final gets integrated into WF10 before 2.0.0.Alpha1.

@bstansberry
Copy link
Contributor

2.0.0.Alpha1 will probably end up in full's master branch tomorrow. The 1.x branch is only being used for full's 9.x.

@wildfly-ci
Copy link

Windows Build 27 is now running using a merge of 3c866ce

@wildfly-ci
Copy link

Core - Full Integration Build 26 is now running using a merge of 3c866ce

@wildfly-ci
Copy link

Linux Build 31 is now running using a merge of 3c866ce

@pferraro
Copy link
Contributor Author

I've updated this PR with your comments from the corresponding master PR. Technically, I don't need this fix until WF10, so I'll leave it to you to decide to merge or not.

@wildfly-ci
Copy link

Windows Build 27 outcome was SUCCESS using a merge of 3c866ce
Summary: Tests passed: 3103, ignored: 66 Build time: 0:20:25

@wildfly-ci
Copy link

Linux Build 31 outcome was SUCCESS using a merge of 3c866ce
Summary: Tests passed: 3103, ignored: 66 Build time: 0:23:01

@wildfly-ci
Copy link

Core - Full Integration Build 26 outcome was SUCCESS using a merge of 3c866ce
Summary: Tests passed: 2845, ignored: 375 Build time: 0:50:37

…om results if another resource exists with the same key as tje target address of a resource alias.
@wildfly-ci
Copy link

Windows Build 29 is now running using a merge of 3ae88af

@wildfly-ci
Copy link

Core - Full Integration Build 28 is now running using a merge of 3ae88af

@wildfly-ci
Copy link

Linux Build 34 is now running using a merge of 3ae88af

@wildfly-ci
Copy link

Windows Build 29 outcome was SUCCESS using a merge of 3ae88af
Summary: Tests passed: 3103, ignored: 66 Build time: 0:20:49

@wildfly-ci
Copy link

Linux Build 34 outcome was SUCCESS using a merge of 3ae88af
Summary: Tests passed: 3103, ignored: 66 Build time: 0:25:59

@wildfly-ci
Copy link

Core - Full Integration Build 28 outcome was SUCCESS using a merge of 3ae88af
Summary: Tests passed: 2845, ignored: 374, muted: 1 Build time: 0:53:50

@bstansberry bstansberry added the ready-for-merge This PR is ready to be merged and fulfills all requirements label May 15, 2015
bstansberry added a commit that referenced this pull request May 15, 2015
[1.x] WFCORE-692 read-children-names(include-aliases=true) can return phantom results
@bstansberry bstansberry merged commit 41edd26 into wildfly:1.x May 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
3 participants