[WFCORE-787] Discard any management model changes before beginning ro…

[bstansberry]

…llback

See http://lists.jboss.org/pipermail/wildfly-dev/2015-July/004170.html

After James Perkins reported WFCORE-788, which looks to be a flaw with the WFCORE-787 fix, I debugged how operations were executing and realized the support in AbstractOperationContext for the no-longer used recursive execution mode was making the logic far too error prone. So I decided to clean that up, and filed WFCORE-792. The second commit in this PR is for that.

Finally, the 3rd commit fixes WFCORE-788 itself by fixing a problem in the CapabilityRegistry copy-on-write behavior where the copy wasn't deep enough, allowing state mutation to leak out of the OperationContext making modifications even if the copy is never published.

[wildfly-ci]

Windows Build 1622 is now running using a merge of 40168e5

[wildfly-ci]

Core - Full Integration Build 1218 is now running using a merge of 40168e5

[wildfly-ci]

Linux Build 2084 is now running using a merge of 40168e5

[wildfly-ci]

Windows Build 1622 outcome was SUCCESS using a merge of 40168e5
Summary: Tests passed: 3348, ignored: 62 Build time: 0:32:25

[wildfly-ci]

Linux Build 2084 outcome was SUCCESS using a merge of 40168e5
Summary: Tests passed: 3348, ignored: 62 Build time: 0:34:42

[wildfly-ci]

Core - Full Integration Build 1218 outcome was SUCCESS using a merge of 40168e5
Summary: Tests passed: 2924, ignored: 371, muted: 1 Build time: 0:47:51

[bstansberry]

Hold while I sort WFCORE-788.

[wildfly-ci]

Windows Build 1627 is now running using a merge of 292e1b2

[wildfly-ci]

Core - Full Integration Build 1224 is now running using a merge of 292e1b2

[wildfly-ci]

Linux Build 2089 is now running using a merge of 292e1b2

[wildfly-ci]

Windows Build 1627 outcome was SUCCESS using a merge of 292e1b2
Summary: Tests passed: 3348, ignored: 62 Build time: 0:32:26

[wildfly-ci]

Core - Full Integration Build 1224 outcome was SUCCESS using a merge of 292e1b2
Summary: Tests passed: 2927, ignored: 371 Build time: 0:47:55

[wildfly-ci]

Linux Build 2089 outcome was FAILURE using a merge of 292e1b2
Summary: Execution timeout (new); tests passed: 3002, ignored: 47; org.wildfly.core:wildfly-core-testsuite-domain Build time: 1:00:08

Build problems:

Execution timeout
Process exited with code 137

[wildfly-ci]

Windows Build 1628 is now running using a merge of 5db8c3e

[wildfly-ci]

Core - Full Integration Build 1225 is now running using a merge of 5db8c3e

[wildfly-ci]

Linux Build 2090 is now running using a merge of 5db8c3e

[wildfly-ci]

Windows Build 1628 outcome was SUCCESS using a merge of 5db8c3e
Summary: Tests passed: 3348, ignored: 62 Build time: 0:32:22

[wildfly-ci]

Linux Build 2090 outcome was SUCCESS using a merge of 5db8c3e
Summary: Tests passed: 3348, ignored: 62 Build time: 0:34:02

[wildfly-ci]

Core - Full Integration Build 1225 outcome was SUCCESS using a merge of 5db8c3e
Summary: Tests passed: 2926, ignored: 371, muted: 1 Build time: 0:48:14

[wildfly-ci]

Windows Build 1629 is now running using a merge of 03628e0

[wildfly-ci]

Linux Build 2091 is now running using a merge of 03628e0

[wildfly-ci]

Core - Full Integration Build 1226 is now running using a merge of 03628e0

[wildfly-ci]

Windows Build 1629 outcome was SUCCESS using a merge of 03628e0
Summary: Tests passed: 3348, ignored: 62 Build time: 0:32:45

[wildfly-ci]

Linux Build 2091 outcome was SUCCESS using a merge of 03628e0
Summary: Tests passed: 3348, ignored: 62 Build time: 0:34:20

[wildfly-ci]

Core - Full Integration Build 1226 outcome was FAILURE using a merge of 03628e0
Summary: Tests failed: 113 (113 new), passed: 2703, ignored: 367, muted: 1 Build time: 0:49:03

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.clustering.single.registry.RegistryTestCase: org.jboss.as.test.clustering.single.singleton.SingletonServiceTestCase: <no details avaliable>

org.jboss.as.test.clustering.single.registry.RegistryTestCase: org.jboss.as.test.clustering.single.provider.ServiceProviderRegistrationTestCase: <no details avaliable>

org.jboss.as.test.clustering.single.registry.RegistryTestCase: org.jboss.as.test.clustering.single.dispatcher.CommandDispatcherTestCase: <no details avaliable>

org.jboss.as.test.clustering.single.registry.RegistryTestCase: org.jboss.as.test.clustering.single.web.SimpleWebTestCase: <no details avaliable>

org.jboss.as.test.clustering.single.registry.RegistryTestCase: <no details avaliable>

org.jboss.as.test.clustering.messaging.ClusteredMessagingTestCase.testClusteredQueue: <no details avaliable>

org.jboss.as.test.clustering.messaging.ClusteredMessagingTestCase.testClusteredTopic: <no details avaliable>

org.jboss.as.test.clustering.xsite.XSiteSimpleTestCase.testPutRelayedToBackups: <no details avaliable>

org.jboss.as.test.clustering.xsite.XSiteSimpleTestCase.testPutToBackupNotRelayed: <no details avaliable>

org.jboss.as.test.multinode.remotecall.scoped.context.DynamicJNDIContextEJBInvocationTestCase: org.jboss.as.test.multinode.ejb.timer.database.DatabaseTimerServiceMultiNodeExecutionDisabledTestCase: <no details avaliable>

org.jboss.as.test.multinode.remotecall.scoped.context.DynamicJNDIContextEJBInvocationTestCase: org.jboss.as.test.multinode.ejb.timer.database.DatabaseTimerServiceMultiNodeTestCase: <no details avaliable>


##### there are 103 more failed tests, see build details

[wildfly-ci]

Core - Full Integration Build 1227 is now running using a merge of 03628e0

[wildfly-ci]

Core - Full Integration Build 1227 outcome was SUCCESS using a merge of 03628e0
Summary: Tests passed: 2928, ignored: 367, muted: 1 Build time: 0:48:24