[WFCORE-774] Memory leak in JBoss CLI

[TomasHofman]

https://issues.jboss.org/browse/WFCORE-774

[wildfly-ci]

Core - Full Integration Build 1264 is now running using a merge of f2140f9

[wildfly-ci]

Linux Build 2130 is now running using a merge of f2140f9

[wildfly-ci]

Windows Build 1663 is now running using a merge of f2140f9

[wildfly-ci]

Windows Build 1663 outcome was SUCCESS using a merge of f2140f9
Summary: Tests passed: 3364, ignored: 63 Build time: 0:33:15

[wildfly-ci]

Linux Build 2130 outcome was SUCCESS using a merge of f2140f9
Summary: Tests passed: 3364, ignored: 63 Build time: 0:34:47

[wildfly-ci]

Core - Full Integration Build 1264 outcome was SUCCESS using a merge of f2140f9
Summary: Tests passed: 2906, ignored: 372, muted: 1 Build time: 0:47:33

[aloubyansky]

There is a method in CommandContext called terminateSession() which is where the clean up should take place when the session is over. Is there anything that could also be added to that method?

[TomasHofman]

Well, the only problem there was that every instance of CommandContextImpl added new JaasConfigurationWrapper to global Configuration (so it was creating longer and longer chain). JaasConfigurationWrappers are also holding references back to CommandContextImpl instances, which prevents those from being garbage collected.

So I see two options:

1. only add JaasConfigurationWrapper to global Configuration in the first CommandContext instance being created (shouldn't affect the functionality as I believe),
2. or remove JaasConfigurationWrapper from the Configuration in terminateSession() and restore original configuration.

Neither option is bullet proof, and I thought 1) is simpler.

[aloubyansky]

@darranl what's your opinion on this?

[aloubyansky]

BTW, Tomas, thanks for your effort here!

[darranl]

Looks fine.

[aloubyansky]

Ok, given that no matter which option we choose it's still a static config at the end, I'm fine with this too.