Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger validation of includes also when a profile/s-g-b is empty #881

Merged
merged 4 commits into from Jul 15, 2015

Conversation

@kabir kabir closed this Jul 13, 2015
@kabir kabir reopened this Jul 13, 2015
@wildfly-ci
Copy link

Windows Build 1689 is now running using a merge of e9edcfa

@wildfly-ci
Copy link

Linux Build 2160 is now running using a merge of e9edcfa

@wildfly-ci
Copy link

Core - Full Integration Build 1295 is now running using a merge of e9edcfa

@wildfly-ci
Copy link

Core - Full Integration Build 1296 is now running using a merge of e9edcfa

@wildfly-ci
Copy link

Linux Build 2161 is now running using a merge of e9edcfa

@wildfly-ci
Copy link

Windows Build 1690 is now running using a merge of e9edcfa

@wildfly-ci
Copy link

Windows Build 1690 outcome was SUCCESS using a merge of e9edcfa
Summary: Tests passed: 3375, ignored: 63 Build time: 0:33:08

@wildfly-ci
Copy link

Windows Build 1689 outcome was SUCCESS using a merge of e9edcfa
Summary: Tests passed: 3375, ignored: 63 Build time: 0:33:38

@wildfly-ci
Copy link

Linux Build 2160 outcome was SUCCESS using a merge of e9edcfa
Summary: Tests passed: 3375, ignored: 63 Build time: 0:34:47

@wildfly-ci
Copy link

Linux Build 2161 outcome was SUCCESS using a merge of e9edcfa
Summary: Tests passed: 3375, ignored: 63 Build time: 0:36:08

@wildfly-ci
Copy link

Core - Full Integration Build 1296 outcome was SUCCESS using a merge of e9edcfa
Summary: Tests passed: 2914, ignored: 342, muted: 1 Build time: 0:51:25

@wildfly-ci
Copy link

Core - Full Integration Build 1295 outcome was FAILURE using a merge of e9edcfa
Summary: Tests failed: 1, passed: 2913, ignored: 342, muted: 1 Build time: 0:51:54

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.ejb.mdb.dynamic.DynamicMessageListenerTestCase.test1: <no details avaliable>

@@ -3332,35 +3333,17 @@ XMLStreamException discoveryOptionsMustBeDeclared(String adminOnlyCmd, String po
@Message(id = 398, value = "An attempt was made to rename the resource found at %s to %s. However, '%s' is one of the resource types defined to be ordered on the parent resource %s")
OperationFailedRuntimeException orderedChildTypeRenamed(PathAddress read, PathAddress transformed, String type, Set<String> parentOrderedChildren);

@Message(id = 399, value = "Model references of type '%s' are missing: %s")
OperationFailedException missingReferences(String type, Set<String> missing);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we ship any of these ids in WildFly 9? If so, they can't be repurposed and should just be commented out if no longer used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 1.0.0.Final (i.e. WF 9) the ids end at 395, so we should be good.
https://github.com/wildfly/wildfly-core/blob/1.0.0.Final/controller/src/main/java/org/jboss/as/controller/logging/ControllerLogger.java

(Not that I actually checked beforehand :-) )

@bstansberry
Copy link
Contributor

Just an FYI, I expect a lot of the validation is going to end up being done via capability resolution.

@bstansberry bstansberry added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Jul 13, 2015
kabir added a commit that referenced this pull request Jul 15, 2015
Trigger validation of includes also when a profile/s-g-b is empty
@kabir kabir merged commit dda0234 into wildfly:master Jul 15, 2015
spyrkob pushed a commit to spyrkob/wildfly-core that referenced this pull request Sep 17, 2020
[JBEAP-19240] Upgrade WildFly Elytron from 1.10.6.Final-redhat-00001 to 1.10.7.Final-redhat-00001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
3 participants