Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFCORE-820] Attribute for-hosts for Security Realm with Kerberos doe… #887

Merged
merged 1 commit into from Jul 22, 2015
Merged

[WFCORE-820] Attribute for-hosts for Security Realm with Kerberos doe… #887

merged 1 commit into from Jul 22, 2015

Conversation

TomasHofman
Copy link
Contributor

@TomasHofman TomasHofman mentioned this pull request Jul 15, 2015
Closed
@wildfly-ci
Copy link

Windows Build 1706 is now running using a merge of b26cecd

@wildfly-ci
Copy link

Core - Full Integration Build 1314 is now running using a merge of b26cecd

@wildfly-ci
Copy link

Linux Build 2178 is now running using a merge of b26cecd

@wildfly-ci
Copy link

Windows Build 1706 outcome was SUCCESS using a merge of b26cecd
Summary: Tests passed: 3380, ignored: 63 Build time: 0:33:54

@wildfly-ci
Copy link

Core - Full Integration Build 1314 outcome was FAILURE using a merge of b26cecd
Summary: Tests failed: 4 (4 new), passed: 2938, ignored: 344, muted: 2 Build time: 0:52:34

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.ejb.mdb.dynamic.DynamicMessageListenerTestCase.test1: <no details avaliable>

org.jboss.as.test.integration.ejb.mdb.ejb2x.MDB20TopicTestCase.testEjb20TopicMDBs: <no details avaliable>

org.jboss.as.test.integration.ws.wsse.signencrypt.SignEncryptMultipleClientsTestCase.encryptedAndSignedRequestFromJohn: <no details avaliable>

org.jboss.as.test.clustering.cluster.ejb.remote.RemoteFailoverTestCase(SYNC-tcp).testConcurrentFailover: <no details avaliable>

@wildfly-ci
Copy link

Linux Build 2178 outcome was FAILURE using a merge of b26cecd
Summary: Execution timeout; tests passed: 3033, ignored: 48; org.wildfly.core:wildfly-core-testsuite-domain Build time: 1:00:06

Build problems:

Execution timeout
Process exited with code 137

@TomasHofman
Copy link
Contributor Author

Retest this please.

@wildfly-ci
Copy link

Core - Full Integration Build 1315 is now running using a merge of b26cecd

@wildfly-ci
Copy link

Windows Build 1707 is now running using a merge of b26cecd

@wildfly-ci
Copy link

Linux Build 2179 is now running using a merge of b26cecd

@wildfly-ci
Copy link

Windows Build 1707 outcome was SUCCESS using a merge of b26cecd
Summary: Tests passed: 3380, ignored: 63 Build time: 0:33:55

@wildfly-ci
Copy link

Linux Build 2179 outcome was SUCCESS using a merge of b26cecd
Summary: Tests passed: 3380, ignored: 63 Build time: 0:35:42

@wildfly-ci
Copy link

Core - Full Integration Build 1315 outcome was FAILURE using a merge of b26cecd
Summary: Tests failed: 1, passed: 2941, ignored: 344, muted: 2 Build time: 0:53:03

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.ejb.mdb.dynamic.DynamicMessageListenerTestCase.test1: <no details avaliable>

bstansberry
bstansberry reviewed Jul 15, 2015
View reviewed changes
server/src/main/resources/schema/jboss-as-config_1_7.xsd
2 - Iterate the list of keytabs and identity one where the for-hosts attribute contains an entry matching hostname.
3 - Iterate the list of keytabs and identify one where the name of the principal matches matches protocol/hostname.
2 - Iterate the list of keytabs and identify one where the name of the principal matches matches protocol/hostname.
3 - Iterate the list of keytabs and identity one where the for-hosts attribute contains an entry matching hostname.
4 - Iterate the list of keytabs and identify one where the hostname portion of the principal matches the hostname of the request.
5 - Use the keytab where for-hosts is set to '*'.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current schema is https://github.com/wildfly/wildfly-core/blob/master/server/src/main/resources/schema/wildfly-config_4_0.xsd

@TomasHofman TomasHofman force-pushed the WFCORE-820 branch 2 times, most recently from a9c2d7a to 15796e6 Compare July 16, 2015 08:38
@wildfly-ci
Copy link

Linux Build 2184 is now running using a merge of 15796e6

@wildfly-ci
Copy link

Windows Build 1711 is now running using a merge of 15796e6

@wildfly-ci
Copy link

Core - Full Integration Build 1321 is now running using a merge of 15796e6

@TomasHofman
Copy link
Contributor Author

Ah, thanks Brian. Didn't realize there may be newer version. So probably only fix the latest one...?

Can I actually change XSD documentation just like that? Should I involve documentation team for some reason?

@wildfly-ci
Copy link

Windows Build 1711 outcome was SUCCESS using a merge of 15796e6
Summary: Tests passed: 3380, ignored: 63 Build time: 0:34:27

@wildfly-ci
Copy link

Linux Build 2184 outcome was SUCCESS using a merge of 15796e6
Summary: Tests passed: 3380, ignored: 63 Build time: 0:35:03

@wildfly-ci
Copy link

Core - Full Integration Build 1321 outcome was SUCCESS using a merge of 15796e6
Summary: Tests passed: 2942, ignored: 344, muted: 3 Build time: 0:50:46

@wildfly-ci
Copy link

Windows Build 1717 is now running using a merge of b71540b

@wildfly-ci
Copy link

Core - Full Integration Build 1327 is now running using a merge of b71540b

@wildfly-ci
Copy link

Linux Build 2190 is now running using a merge of b71540b

@wildfly-ci
Copy link

Windows Build 1717 outcome was SUCCESS using a merge of b71540b
Summary: Tests passed: 3380, ignored: 63 Build time: 0:33:59

@wildfly-ci
Copy link

Linux Build 2190 outcome was SUCCESS using a merge of b71540b
Summary: Tests passed: 3380, ignored: 63 Build time: 0:36:12

@wildfly-ci
Copy link

Core - Full Integration Build 1327 outcome was FAILURE using a merge of b71540b
Summary: Tests failed: 2 (2 new), passed: 2941, ignored: 344, muted: 2 Build time: 0:53:20

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.ejb.mdb.dynamic.DynamicMessageListenerTestCase.test1: <no details avaliable>

org.jboss.as.test.clustering.cluster.ejb.remote.RemoteFailoverTestCase(SYNC-tcp).testStatefulFailover: <no details avaliable>

@bstansberry
Copy link
Contributor

Hi Tomas,

Sorry, I didn't check back to see your comment.

Generally we don't update schemas once they are published in a final release. It's confusing to have different variations of the same schema out there on the internet. So just the latest is ok.

If you need to fix BZ 1228228 (currently it's not triaged for inclusion in a CP and I doubt it ever will be) and someone insists on updating the 1.7 schema as the fix, we won't object to changing it in WildFly Core as well.

Re: docs, probably the simplest thing to do is change the "Doc Type" on the BZ to Known Issue and fill in the Doc Text. I believe that will provide the info needed to create an entry in the EAP Release Notes if docs wants one.

@bstansberry bstansberry added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Jul 21, 2015
@bstansberry
Copy link
Contributor

retest this please

@wildfly-ci
Copy link

Windows Build 1767 is now running using a merge of b71540b

@wildfly-ci
Copy link

Linux Build 2242 is now running using a merge of b71540b

@wildfly-ci
Copy link

Core - Full Integration Build 1378 is now running using a merge of b71540b

@wildfly-ci
Copy link

Windows Build 1767 outcome was SUCCESS using a merge of b71540b
Summary: Tests passed: 3382, ignored: 63 Build time: 0:34:03

@wildfly-ci
Copy link

Linux Build 2242 outcome was SUCCESS using a merge of b71540b
Summary: Tests passed: 3382, ignored: 63 Build time: 0:34:53

@wildfly-ci
Copy link

Core - Full Integration Build 1378 outcome was FAILURE using a merge of b71540b
Summary: Tests failed: 1 (1 new), passed: 2954, ignored: 355 Build time: 0:47:29

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.ejb.client.descriptor.EJBClientDescriptorTestCase.testClientPropertiesReplacementInConfig: <no details avaliable>

bstansberry added a commit that referenced this pull request Jul 22, 2015
@bstansberry
Merge pull request #887 from TomasHofman/WFCORE-820
2c5aff2 
[WFCORE-820] Attribute for-hosts for Security Realm with Kerberos doe…
@bstansberry bstansberry merged commit 2c5aff2 into wildfly:master Jul 22, 2015
spyrkob pushed a commit to spyrkob/wildfly-core that referenced this pull request Sep 17, 2020
@jmesnil
Merge pull request wildfly#887 from spyrkob/JBEAP-19689
e0c16c0 
[WFCORE-4690] Fix the test suite tests to work with Eclipse OpenJ9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Milestone
No milestone
3 participants
@TomasHofman @wildfly-ci @bstansberry