WFCORE-671 : Configuration change reporting. #890

ehsavoie · 2015-07-16T12:30:04Z

Adding new collector
Creating a resource for configuration-changes configuration.
Securing operations :
* if the user can't access the resource addressed by the operation then the operation information are not displayed but the entry point is kept (aka date, result).
* if the user can access the address but doesn't have the rights to run the operation then the parameters are not accessible in the operation description.

Providing an in-memory audit-logger to track configuration changes easily.

Jira: https://issues.jboss.org/browse/WFCORE-671

wildfly-ci · 2015-07-16T12:33:35Z

Core - Full Integration Build 1324 is now running using a merge of 4e869ff

wildfly-ci · 2015-07-16T12:33:37Z

Linux Build 2187 is now running using a merge of 4e869ff

wildfly-ci · 2015-07-16T12:33:39Z

Windows Build 1714 is now running using a merge of 4e869ff

wildfly-ci · 2015-07-16T13:10:13Z

Windows Build 1714 outcome was SUCCESS using a merge of 4e869ff
Summary: Tests passed: 3390, ignored: 63 Build time: 0:36:38

wildfly-ci · 2015-07-16T13:12:11Z

Linux Build 2187 outcome was SUCCESS using a merge of 4e869ff
Summary: Tests passed: 3390, ignored: 63 Build time: 0:38:37

wildfly-ci · 2015-07-16T13:27:29Z

Core - Full Integration Build 1324 outcome was FAILURE using a merge of 4e869ff
Summary: Tests failed: 19 (19 new), passed: 2924, ignored: 344, muted: 2 Build time: 0:53:55

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.smoke.subsystem.xml.XSDValidationUnitTestCase.testJBossXsds: <no details avaliable>

org.jboss.as.test.smoke.subsystem.xml.StandardConfigsXMLValidationUnitTestCase.testStandaloneEC2FullHA: <no details avaliable>

org.jboss.as.test.smoke.subsystem.xml.StandardConfigsXMLValidationUnitTestCase.testHostMaster: <no details avaliable>

org.jboss.as.test.smoke.subsystem.xml.StandardConfigsXMLValidationUnitTestCase.testStandalone: <no details avaliable>

org.jboss.as.test.smoke.subsystem.xml.StandardConfigsXMLValidationUnitTestCase.testHost: <no details avaliable>

org.jboss.as.test.smoke.subsystem.xml.StandardConfigsXMLValidationUnitTestCase.testStandaloneHA: <no details avaliable>

org.jboss.as.test.smoke.subsystem.xml.StandardConfigsXMLValidationUnitTestCase.testStandaloneJTS: <no details avaliable>

org.jboss.as.test.smoke.subsystem.xml.StandardConfigsXMLValidationUnitTestCase.testStandaloneRTS: <no details avaliable>

org.jboss.as.test.smoke.subsystem.xml.StandardConfigsXMLValidationUnitTestCase.testStandaloneXTS: <no details avaliable>

org.jboss.as.test.smoke.subsystem.xml.StandardConfigsXMLValidationUnitTestCase.testStandaloneGossipHA: <no details avaliable>

org.jboss.as.test.smoke.subsystem.xml.StandardConfigsXMLValidationUnitTestCase.testHostSlave: <no details avaliable>


##### there are 9 more failed tests, see build details

wildfly-ci · 2015-07-16T15:59:46Z

Core - Full Integration Build 1330 is now running using a merge of 4e869ff

wildfly-ci · 2015-07-16T16:38:34Z

Windows Build 1721 is now running using a merge of 4a55c1a

wildfly-ci · 2015-07-16T16:38:34Z

Linux Build 2193 is now running using a merge of 4a55c1a

wildfly-ci · 2015-07-16T16:38:35Z

Core - Full Integration Build 1331 is now running using a merge of 4a55c1a

wildfly-ci · 2015-07-16T16:46:53Z

Core - Full Integration Build 1330 outcome was FAILURE using a merge of 4a55c1a
Summary: Tests failed: 18, passed: 2916, ignored: 349 Build time: 0:47:07

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.smoke.subsystem.xml.XSDValidationUnitTestCase.testJBossXsds: <no details avaliable>

org.jboss.as.test.smoke.subsystem.xml.StandardConfigsXMLValidationUnitTestCase.testStandaloneEC2FullHA: <no details avaliable>

org.jboss.as.test.smoke.subsystem.xml.StandardConfigsXMLValidationUnitTestCase.testHostMaster: <no details avaliable>

org.jboss.as.test.smoke.subsystem.xml.StandardConfigsXMLValidationUnitTestCase.testStandalone: <no details avaliable>

org.jboss.as.test.smoke.subsystem.xml.StandardConfigsXMLValidationUnitTestCase.testHost: <no details avaliable>

org.jboss.as.test.smoke.subsystem.xml.StandardConfigsXMLValidationUnitTestCase.testStandaloneHA: <no details avaliable>

org.jboss.as.test.smoke.subsystem.xml.StandardConfigsXMLValidationUnitTestCase.testStandaloneJTS: <no details avaliable>

org.jboss.as.test.smoke.subsystem.xml.StandardConfigsXMLValidationUnitTestCase.testStandaloneRTS: <no details avaliable>

org.jboss.as.test.smoke.subsystem.xml.StandardConfigsXMLValidationUnitTestCase.testStandaloneXTS: <no details avaliable>

org.jboss.as.test.smoke.subsystem.xml.StandardConfigsXMLValidationUnitTestCase.testStandaloneGossipHA: <no details avaliable>

org.jboss.as.test.smoke.subsystem.xml.StandardConfigsXMLValidationUnitTestCase.testHostSlave: <no details avaliable>


##### there are 8 more failed tests, see build details

wildfly-ci · 2015-07-16T17:12:49Z

Windows Build 1721 outcome was FAILURE using a merge of 4a55c1a
Summary: Tests failed: 1 (1 new), passed: 3389, ignored: 63 Build time: 0:34:15

Build problems:

Failed tests detected

Failed tests

org.jboss.as.jmx.rbac.JmxRbacDisabledTestCase.testMaintainerSensitiveMBeans: <no details avaliable>

wildfly-ci · 2015-07-16T17:15:15Z

Linux Build 2193 outcome was SUCCESS using a merge of 4a55c1a
Summary: Tests passed: 3390, ignored: 63 Build time: 0:36:42

wildfly-ci · 2015-07-16T17:25:05Z

Core - Full Integration Build 1331 outcome was SUCCESS using a merge of 4a55c1a
Summary: Tests passed: 2934, ignored: 349 Build time: 0:46:31

ehsavoie · 2015-07-16T17:42:20Z

Retest this please

wildfly-ci · 2015-07-16T17:43:35Z

Linux Build 2196 is now running using a merge of 4a55c1a

wildfly-ci · 2015-07-16T17:43:35Z

Windows Build 1724 is now running using a merge of 4a55c1a

wildfly-ci · 2015-07-16T17:43:36Z

Core - Full Integration Build 1334 is now running using a merge of 4a55c1a

wildfly-ci · 2015-07-16T18:18:52Z

Windows Build 1724 outcome was SUCCESS using a merge of 4a55c1a
Summary: Tests passed: 3390, ignored: 63 Build time: 0:35:18

wildfly-ci · 2015-07-16T18:19:06Z

Linux Build 2196 outcome was SUCCESS using a merge of 4a55c1a
Summary: Tests passed: 3390, ignored: 63 Build time: 0:35:31

wildfly-ci · 2015-07-16T18:28:36Z

Core - Full Integration Build 1334 outcome was FAILURE using a merge of 4a55c1a
Summary: Tests failed: 2 (2 new), passed: 2927, ignored: 350 Build time: 0:45:01

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.ejb.security.jbossappxml.JBossAppXMLSecurityTestCase.testEJBRunAs: <no details avaliable>

org.jboss.as.test.integration.messaging.mgmt.ConnectionFactoryManagementTestCase.testWriteDiscoveryGroupAttributeWhenConnectorIsAlreadyDefined: <no details avaliable>

bstansberry · 2015-07-20T19:43:06Z

retest this please

wildfly-ci · 2015-07-20T19:43:45Z

Windows Build 1758 is now running using a merge of 4a55c1a

wildfly-ci · 2015-07-20T19:43:45Z

Core - Full Integration Build 1369 is now running using a merge of 4a55c1a

wildfly-ci · 2015-07-20T19:43:47Z

Linux Build 2232 is now running using a merge of 4a55c1a

bstansberry · 2015-07-20T19:52:51Z

...ment/src/main/java/org/jboss/as/domain/management/ConfigurationChangeResourceDefinition.java

+
+        @Override
+        public void execute(OperationContext context, ModelNode operation) throws OperationFailedException {
+            ModelNode maxHistory = MAX_HISTORY.resolveModelAttribute(context, operation);


This isn't correct for a write-attribute op handler, which has params (name=max-history,value=15), not (max-history=15).

wildfly-ci · 2015-07-20T20:17:07Z

Windows Build 1758 outcome was SUCCESS using a merge of 4a55c1a
Summary: Tests passed: 3390, ignored: 63 Build time: 0:33:22

wildfly-ci · 2015-07-20T20:18:43Z

Linux Build 2232 outcome was SUCCESS using a merge of 4a55c1a
Summary: Tests passed: 3390, ignored: 63 Build time: 0:34:58

wildfly-ci · 2015-07-20T20:30:21Z

Core - Full Integration Build 1369 outcome was FAILURE using a merge of 4a55c1a
Summary: Tests failed: 1 (1 new), passed: 2955, ignored: 354 Build time: 0:46:36

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.ee.appclient.basic.SimpleApplicationClientTestCase.testAppClientJBossDescriptor: <no details avaliable>

wildfly-ci · 2015-07-21T17:03:51Z

Windows Build 1766 is now running using a merge of 6a62f8b

wildfly-ci · 2015-07-21T17:03:51Z

Linux Build 2241 is now running using a merge of 6a62f8b

wildfly-ci · 2015-07-21T17:03:52Z

Core - Full Integration Build 1377 is now running using a merge of 6a62f8b

wildfly-ci · 2015-07-21T17:37:30Z

Windows Build 1766 outcome was SUCCESS using a merge of 6a62f8b
Summary: Tests passed: 3392, ignored: 63 Build time: 0:33:39

wildfly-ci · 2015-07-21T17:40:18Z

Linux Build 2241 outcome was SUCCESS using a merge of 6a62f8b
Summary: Tests passed: 3392, ignored: 63 Build time: 0:36:27

wildfly-ci · 2015-07-21T17:49:11Z

Core - Full Integration Build 1377 outcome was FAILURE using a merge of 6a62f8b
Summary: Tests failed: 1 (1 new), passed: 2954, ignored: 355 Build time: 0:45:21

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.ejb.remote.client.api.interceptor.EJBClientInterceptorTestCase.testEJBClientInterceptionFromInVMClient: <no details avaliable>

Adding new collector Creating a resource for configuration-changes configuration. Securing operations : * if the user can't access the resource addressed by the operation then the operation information are not displayed but the entry point is kept (aka date, result). * if the user can access the address but doesn't have the rights to run the operation then the parameters are not accessible in the operation description.

Providing an in-memory audit-logger to track configuration changes easily.

wildfly-ci · 2015-07-23T18:03:50Z

Linux Build 2256 is now running using a merge of 43b4015

wildfly-ci · 2015-07-23T18:03:50Z

Windows Build 1779 is now running using a merge of 43b4015

wildfly-ci · 2015-07-23T18:03:51Z

Core - Full Integration Build 1395 is now running using a merge of 43b4015

bstansberry · 2015-07-23T18:30:57Z

...ain/java/org/jboss/as/domain/management/audit/InMemoryAuditLogHandlerResourceDefinition.java

+
+    public static final String OPERATION_NAME = "show-logs";
+    protected static final AttributeDefinition[] ATTRIBUTES = new AttributeDefinition[]{MAX_OPERATION_COUNT};
+    private static final Map<String, InMemoryAuditLogHander> histories = Collections.synchronizedMap(new HashMap<String, InMemoryAuditLogHander>());


I don't want to delay merging this PR for this, but once it's merged please send up a PR to make this a non-static field and have the InMemoryAuditLogHandlerResourceDefinition pass a ref to it to the handlers when it constructs them.

Having this be static is no big deal in this case, but I don't want anyone looking at kernel code and thinking that using static fields to store state is a good practice.

wildfly-ci · 2015-07-23T18:39:17Z

Windows Build 1779 outcome was FAILURE using a merge of 43b4015
Summary: Tests failed: 2 (2 new), passed: 3396, ignored: 63 Build time: 0:35:28

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.manualmode.auditlog.AuditLogBootingLogTestCase.testBootIsLogged: <no details avaliable>

org.jboss.as.test.manualmode.auditlog.AuditLogFieldsOfLogTestCase.testAuditLoggingFields: <no details avaliable>

wildfly-ci · 2015-07-23T18:40:06Z

Linux Build 2256 outcome was SUCCESS using a merge of 43b4015
Summary: Tests passed: 3398, ignored: 63 Build time: 0:36:17

wildfly-ci · 2015-07-23T18:51:43Z

Core - Full Integration Build 1395 outcome was FAILURE using a merge of 43b4015
Summary: Tests failed: 4 (4 new), passed: 2945, ignored: 354 Build time: 0:47:54

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.naming.connector.JMXConnectorTestCase.testMBeanCount: <no details avaliable>

org.jboss.as.test.integration.security.passwordmasking.PasswordMaskingInContainerTestCase.datasourceOperationsTest: <no details avaliable>

org.jboss.as.test.integration.security.vault.VaultDatasourceTestCase.testAccessThroughVaultDatasource: <no details avaliable>

org.jboss.as.test.manualmode.web.ssl.DatabaseCertLoginModuleTestCase.testDatabaseCertLoginModule: <no details avaliable>

WFCORE-671 : Configuration change reporting.

[JBEAP-19670][WCORE-5014] Remove the PropertySorter and specially handle the file …

ehsavoie force-pushed the WFCORE-671 branch from 4e869ff to 4a55c1a Compare July 16, 2015 16:34

bstansberry reviewed Jul 20, 2015
View reviewed changes

ehsavoie force-pushed the WFCORE-671 branch 2 times, most recently from d9eaea9 to 6a62f8b Compare July 21, 2015 17:02

ehsavoie added 2 commits July 23, 2015 18:49

[WFCORE-671] : Using AuditLogHandler

43b4015

Providing an in-memory audit-logger to track configuration changes easily.

ehsavoie force-pushed the WFCORE-671 branch from 6a62f8b to 43b4015 Compare July 23, 2015 18:02

bstansberry reviewed Jul 23, 2015
View reviewed changes

bstansberry added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Jul 23, 2015

bstansberry added a commit that referenced this pull request Jul 23, 2015

Merge pull request #890 from ehsavoie/WFCORE-671

f6d4aba

WFCORE-671 : Configuration change reporting.

bstansberry merged commit f6d4aba into wildfly:master Jul 23, 2015

ehsavoie deleted the WFCORE-671 branch September 1, 2016 09:20

spyrkob pushed a commit to spyrkob/wildfly-core that referenced this pull request Sep 17, 2020

Merge pull request wildfly#890 from gaol/JBEAP-19670

d084772

[JBEAP-19670][WCORE-5014] Remove the PropertySorter and specially handle the file …

WFCORE-671 : Configuration change reporting. #890

WFCORE-671 : Configuration change reporting. #890

Conversation

ehsavoie commented Jul 16, 2015

wildfly-ci commented Jul 16, 2015

wildfly-ci commented Jul 16, 2015

wildfly-ci commented Jul 16, 2015

wildfly-ci commented Jul 16, 2015

wildfly-ci commented Jul 16, 2015

wildfly-ci commented Jul 16, 2015

Build problems:

Failed tests

wildfly-ci commented Jul 16, 2015

wildfly-ci commented Jul 16, 2015

wildfly-ci commented Jul 16, 2015

wildfly-ci commented Jul 16, 2015

wildfly-ci commented Jul 16, 2015

Build problems:

Failed tests

wildfly-ci commented Jul 16, 2015

Build problems:

Failed tests

wildfly-ci commented Jul 16, 2015

wildfly-ci commented Jul 16, 2015

ehsavoie commented Jul 16, 2015

wildfly-ci commented Jul 16, 2015

wildfly-ci commented Jul 16, 2015

wildfly-ci commented Jul 16, 2015

wildfly-ci commented Jul 16, 2015

wildfly-ci commented Jul 16, 2015

wildfly-ci commented Jul 16, 2015

Build problems:

Failed tests

bstansberry commented Jul 20, 2015

wildfly-ci commented Jul 20, 2015

wildfly-ci commented Jul 20, 2015

wildfly-ci commented Jul 20, 2015

bstansberry Jul 20, 2015

Choose a reason for hiding this comment

wildfly-ci commented Jul 20, 2015

wildfly-ci commented Jul 20, 2015

wildfly-ci commented Jul 20, 2015

Build problems:

Failed tests

wildfly-ci commented Jul 21, 2015

wildfly-ci commented Jul 21, 2015

wildfly-ci commented Jul 21, 2015

wildfly-ci commented Jul 21, 2015

wildfly-ci commented Jul 21, 2015

wildfly-ci commented Jul 21, 2015

Build problems:

Failed tests

wildfly-ci commented Jul 23, 2015

wildfly-ci commented Jul 23, 2015

wildfly-ci commented Jul 23, 2015

bstansberry Jul 23, 2015

Choose a reason for hiding this comment

wildfly-ci commented Jul 23, 2015

Build problems:

Failed tests

wildfly-ci commented Jul 23, 2015

wildfly-ci commented Jul 23, 2015

Build problems:

Failed tests