New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AESH Upgrade and associated CLI refactoring #904
Conversation
Core - Full Integration Build 1354 is now running using a merge of d4b56aa |
Linux Build 2216 is now running using a merge of d4b56aa |
Windows Build 1742 is now running using a merge of d4b56aa |
Windows Build 1742 outcome was SUCCESS using a merge of d4b56aa |
Linux Build 2216 outcome was SUCCESS using a merge of d4b56aa |
Core - Full Integration Build 1354 outcome was FAILURE using a merge of d4b56aa Build problems:Failed tests detected Failed tests
|
Most of these errors don't make sense. The line described, CLITestUtil 70, was changed. There shouldn't be a reference to the old AESH Settings.getInstance() anymore. Somehow the wildfly-integration test run seems to be getting the new AESH 0.62, which doesn't contain the Settings class anymore, but is still using the current CLITestUtil rather than the new one in the commit. |
Core - Full Integration Build 1357 is now running using a merge of d4b56aa |
Core - Full Integration Build 1357 outcome was FAILURE using a merge of d4b56aa Build problems:Failed tests detected Failed tests
|
The testsuite/shared/pom.xml in full is directly declaring the org.wildfly.core:wildfly-core-testsuite-shared version instead of relying on dependency-management in the parent:
I don't know why that would fail though. The -Dversion.org.wildfly.core=2.0.0.Alpha11-SNAPSHOT passed to maven should still be resulting in the correct version being used. |
Windows Build 1761 is now running using a merge of a60b024 |
Core - Full Integration Build 1372 is now running using a merge of a60b024 |
Linux Build 2236 is now running using a merge of a60b024 |
<artifactId>wildfly-core-testsuite-shared</artifactId> | ||
<version>${project.version}</version> | ||
</dependency> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if adding the testsuite-shared dependency to the dependencyManagement in the root pom is an acceptable way to solve this problem, but it seemed to work locally. If it passes at least it gives us a clue to the cause.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any reason what that module shouldn't be declared there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OT: this is just my personal opinion and isn't any sort of policy, but I quite dislike org.wildfly.core:wildfly-core-testsuite-shared being used outside of WildFly Core. I don't think people working on a testsuite utility module will put the kind of care into it that's appropriate for public API used by other projects.
Please don't regard ^^^ as being anything more than me preaching a bit hoping someone else will eventually convert to my faith. ;)
Windows Build 1761 outcome was SUCCESS using a merge of a60b024 |
Linux Build 2236 outcome was SUCCESS using a merge of a60b024 |
Core - Full Integration Build 1372 outcome was FAILURE using a merge of a60b024 Build problems:Failed tests detected Failed tests
|
retest this please |
Linux Build 2237 is now running using a merge of a60b024 |
Windows Build 1762 is now running using a merge of a60b024 |
Core - Full Integration Build 1373 is now running using a merge of a60b024 |
Windows Build 1762 outcome was FAILURE using a merge of a60b024 Build problems:Failed tests detected Failed tests
|
Linux Build 2237 outcome was SUCCESS using a merge of a60b024 |
Core - Full Integration Build 1373 outcome was FAILURE using a merge of a60b024 Build problems:Failed tests detected Failed tests
|
retest this please |
Linux Build 2250 is now running using a merge of a60b024 |
Windows Build 1774 is now running using a merge of a60b024 |
Core - Full Integration Build 1387 is now running using a merge of a60b024 |
Windows Build 1774 outcome was SUCCESS using a merge of a60b024 |
Linux Build 2250 outcome was SUCCESS using a merge of a60b024 |
Core - Full Integration Build 1393 outcome was FAILURE using a merge of a60b024 Build problems:Failed tests detected Failed tests
|
Linux Build 2255 outcome was SUCCESS using a merge of a60b024 |
retest this please http://brontes.lab.eng.brq.redhat.com/viewLog.html?buildId=62070&tab=buildResultsDiv&buildTypeId=WF_WildFlyCoreIntegrationExperiments looked good and I've merged wildfly/wildfly#7823 |
Windows Build 1780 is now running using a merge of a60b024 |
Core - Full Integration Build 1396 is now running using a merge of a60b024 |
Linux Build 2257 is now running using a merge of a60b024 |
Windows Build 1780 outcome was FAILURE using a merge of a60b024 Build problems:Process exited with code 1 |
Linux Build 2257 outcome was FAILURE using a merge of a60b024 Build problems:Process exited with code 1 |
Core - Full Integration Build 1396 outcome was SUCCESS using a merge of a60b024 |
…ing Issue in pom.
Windows Build 1783 is now running using a merge of c35ad01 |
Linux Build 2261 is now running using a merge of c35ad01 |
Core - Full Integration Build 1399 is now running using a merge of c35ad01 |
Windows Build 1783 outcome was FAILURE using a merge of c35ad01 Build problems:Failed tests detected Failed tests
|
Linux Build 2261 outcome was SUCCESS using a merge of c35ad01 |
Core - Full Integration Build 1399 outcome was FAILURE using a merge of c35ad01 Build problems:Failed tests detected Failed tests
|
retest this please |
Windows Build 1784 is now running using a merge of c35ad01 |
Linux Build 2262 is now running using a merge of c35ad01 |
Core - Full Integration Build 1400 is now running using a merge of c35ad01 |
Windows Build 1784 outcome was SUCCESS using a merge of c35ad01 |
Linux Build 2262 outcome was SUCCESS using a merge of c35ad01 |
Core - Full Integration Build 1400 outcome was FAILURE using a merge of c35ad01 Build problems:Failed tests detected Failed tests
|
These seem unrelated. The 4 similar failures from the last 2 attempts also failed in 3 other recent PR builds. Can't replicate them locally with or without this commit. |
AESH Upgrade and associated CLI refactoring
The last 4 failures were due to some process being left around on the CI agent. The 2nd one Jeff Mesnil is about to fix (unrelated). The first is a known intermittent failure. |
No description provided.