Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AESH Upgrade and associated CLI refactoring #904

Merged
merged 1 commit into from Jul 24, 2015
Merged

AESH Upgrade and associated CLI refactoring #904

merged 1 commit into from Jul 24, 2015

Conversation

Gonthim
Copy link
Contributor

@Gonthim Gonthim commented Jul 18, 2015

No description provided.

@wildfly-ci
Copy link

Core - Full Integration Build 1354 is now running using a merge of d4b56aa

@wildfly-ci
Copy link

Linux Build 2216 is now running using a merge of d4b56aa

@wildfly-ci
Copy link

Windows Build 1742 is now running using a merge of d4b56aa

@wildfly-ci
Copy link

Windows Build 1742 outcome was SUCCESS using a merge of d4b56aa
Summary: Tests passed: 3375, ignored: 63 Build time: 0:34:01

@wildfly-ci
Copy link

Linux Build 2216 outcome was SUCCESS using a merge of d4b56aa
Summary: Tests passed: 3375, ignored: 63 Build time: 0:35:10

@wildfly-ci
Copy link

Core - Full Integration Build 1354 outcome was FAILURE using a merge of d4b56aa
Summary: Tests failed: 21 (21 new), passed: 2920, ignored: 354 Build time: 0:44:50

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.management.cli.DeploymentArchiveTestCase: org.jboss.as.test.integration.management.cli.DataSourceTestCase: <no details avaliable>

org.jboss.as.test.integration.management.cli.DeploymentArchiveTestCase: org.jboss.as.test.integration.management.cli.DeployTestCase: <no details avaliable>

org.jboss.as.test.integration.management.cli.DeploymentArchiveTestCase: org.jboss.as.test.integration.management.cli.DeployURLTestCase: <no details avaliable>

org.jboss.as.test.integration.management.cli.DeploymentArchiveTestCase: org.jboss.as.test.integration.management.cli.DeployWithRuntimeNameTestCase: <no details avaliable>

org.jboss.as.test.integration.management.cli.DeploymentArchiveTestCase: <no details avaliable>

org.jboss.as.test.integration.management.cli.JmsTestCase: org.jboss.as.test.integration.management.cli.DeploymentScannerTestCase: <no details avaliable>

org.jboss.as.test.integration.management.cli.JmsTestCase: <no details avaliable>

org.jboss.as.test.integration.management.cli.objectstore.TransactionObjectStoreTestCase: org.jboss.as.test.integration.management.cli.WildCardReadsTestCase: <no details avaliable>

org.jboss.as.test.integration.management.cli.objectstore.TransactionObjectStoreTestCase: <no details avaliable>

org.jboss.as.test.integration.security.cli.JsseTestCase: <no details avaliable>

org.jboss.as.test.integration.security.perimeter.CLISecurityTestCase.testConnect: <no details avaliable>


##### there are 11 more failed tests, see build details

@Gonthim
Copy link
Contributor Author

Gonthim commented Jul 18, 2015

Most of these errors don't make sense. The line described, CLITestUtil 70, was changed. There shouldn't be a reference to the old AESH Settings.getInstance() anymore.

Somehow the wildfly-integration test run seems to be getting the new AESH 0.62, which doesn't contain the Settings class anymore, but is still using the current CLITestUtil rather than the new one in the commit.

@wildfly-ci
Copy link

Core - Full Integration Build 1357 is now running using a merge of d4b56aa

@wildfly-ci
Copy link

Core - Full Integration Build 1357 outcome was FAILURE using a merge of d4b56aa
Summary: Tests failed: 21, passed: 2920, ignored: 354 Build time: 0:44:39

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.management.cli.DeploymentArchiveTestCase: org.jboss.as.test.integration.management.cli.DataSourceTestCase: <no details avaliable>

org.jboss.as.test.integration.management.cli.DeploymentArchiveTestCase: org.jboss.as.test.integration.management.cli.DeployTestCase: <no details avaliable>

org.jboss.as.test.integration.management.cli.DeploymentArchiveTestCase: org.jboss.as.test.integration.management.cli.DeployURLTestCase: <no details avaliable>

org.jboss.as.test.integration.management.cli.DeploymentArchiveTestCase: org.jboss.as.test.integration.management.cli.DeployWithRuntimeNameTestCase: <no details avaliable>

org.jboss.as.test.integration.management.cli.DeploymentArchiveTestCase: <no details avaliable>

org.jboss.as.test.integration.management.cli.JmsTestCase: org.jboss.as.test.integration.management.cli.DeploymentScannerTestCase: <no details avaliable>

org.jboss.as.test.integration.management.cli.JmsTestCase: <no details avaliable>

org.jboss.as.test.integration.management.cli.objectstore.TransactionObjectStoreTestCase: org.jboss.as.test.integration.management.cli.WildCardReadsTestCase: <no details avaliable>

org.jboss.as.test.integration.management.cli.objectstore.TransactionObjectStoreTestCase: <no details avaliable>

org.jboss.as.test.integration.security.cli.JsseTestCase: <no details avaliable>

org.jboss.as.test.integration.security.perimeter.CLISecurityTestCase.testConnect: <no details avaliable>


##### there are 11 more failed tests, see build details

@bstansberry
Copy link
Contributor

The testsuite/shared/pom.xml in full is directly declaring the org.wildfly.core:wildfly-core-testsuite-shared version instead of relying on dependency-management in the parent:

            <!-- Not defined in the parent pom as this should only be used here -->
            <dependency>
                <groupId>org.wildfly.core</groupId>
                <artifactId>wildfly-core-testsuite-shared</artifactId>
                <version>${version.org.wildfly.core}</version>
            </dependency>

I don't know why that would fail though. The -Dversion.org.wildfly.core=2.0.0.Alpha11-SNAPSHOT passed to maven should still be resulting in the correct version being used.

@wildfly-ci
Copy link

Windows Build 1761 is now running using a merge of a60b024

@wildfly-ci
Copy link

Core - Full Integration Build 1372 is now running using a merge of a60b024

@wildfly-ci
Copy link

Linux Build 2236 is now running using a merge of a60b024

<artifactId>wildfly-core-testsuite-shared</artifactId>
<version>${project.version}</version>
</dependency>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if adding the testsuite-shared dependency to the dependencyManagement in the root pom is an acceptable way to solve this problem, but it seemed to work locally. If it passes at least it gives us a clue to the cause.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any reason what that module shouldn't be declared there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OT: this is just my personal opinion and isn't any sort of policy, but I quite dislike org.wildfly.core:wildfly-core-testsuite-shared being used outside of WildFly Core. I don't think people working on a testsuite utility module will put the kind of care into it that's appropriate for public API used by other projects.

Please don't regard ^^^ as being anything more than me preaching a bit hoping someone else will eventually convert to my faith. ;)

@wildfly-ci
Copy link

Windows Build 1761 outcome was SUCCESS using a merge of a60b024
Summary: Tests passed: 3377, ignored: 63 Build time: 0:35:18

@wildfly-ci
Copy link

Linux Build 2236 outcome was SUCCESS using a merge of a60b024
Summary: Tests passed: 3377, ignored: 63 Build time: 0:36:11

@wildfly-ci
Copy link

Core - Full Integration Build 1372 outcome was FAILURE using a merge of a60b024
Summary: Tests failed: 209 (206 new), passed: 2272, ignored: 339 Build time: 0:37:02

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.ejb.security.jbossappxml.JBossAppXMLSecurityTestCase.testEJBRunAs: <no details avaliable>

org.jboss.as.test.integration.ejb.timerservice.serialization.TimerServiceSerializationSecondTestCase: org.jboss.as.test.integration.ejb.timerservice.persistence.TimerServicePersistenceSecondTestCase: <no details avaliable>

org.jboss.as.test.integration.ejb.timerservice.serialization.TimerServiceSerializationSecondTestCase: org.jboss.as.test.integration.ejb.timerservice.schedule.SimpleScheduleSecondTestCase: <no details avaliable>

org.jboss.as.test.integration.ejb.timerservice.serialization.TimerServiceSerializationSecondTestCase: <no details avaliable>

org.jboss.as.test.integration.security.loginmodules.LdapLoginModuleTestCase: org.jboss.as.test.integration.jca.moduledeployment.BasicFlatTestCase: <no details avaliable>

org.jboss.as.test.integration.security.loginmodules.LdapLoginModuleTestCase: org.jboss.as.test.integration.jca.moduledeployment.BasicJarTestCase: <no details avaliable>

org.jboss.as.test.integration.security.loginmodules.LdapLoginModuleTestCase: org.jboss.as.test.integration.jca.moduledeployment.InflowFlatTestCase: <no details avaliable>

org.jboss.as.test.integration.security.loginmodules.LdapLoginModuleTestCase: org.jboss.as.test.integration.jca.moduledeployment.InflowJarTestCase: <no details avaliable>

org.jboss.as.test.integration.security.loginmodules.LdapLoginModuleTestCase: org.jboss.as.test.integration.jca.moduledeployment.MultiActivationFlatTestCase: <no details avaliable>

org.jboss.as.test.integration.security.loginmodules.LdapLoginModuleTestCase: org.jboss.as.test.integration.jca.moduledeployment.MultiActivationJarTestCase: <no details avaliable>

org.jboss.as.test.integration.security.loginmodules.LdapLoginModuleTestCase: org.jboss.as.test.integration.jca.moduledeployment.MultiObjectActivationFlatTestCase: <no details avaliable>


##### there are 199 more failed tests, see build details

@Gonthim
Copy link
Contributor Author

Gonthim commented Jul 21, 2015

retest this please

@wildfly-ci
Copy link

Linux Build 2237 is now running using a merge of a60b024

@wildfly-ci
Copy link

Windows Build 1762 is now running using a merge of a60b024

@wildfly-ci
Copy link

Core - Full Integration Build 1373 is now running using a merge of a60b024

@wildfly-ci
Copy link

Windows Build 1762 outcome was FAILURE using a merge of a60b024
Summary: Tests failed: 1 (1 new), passed: 3376, ignored: 63 Build time: 0:34:24

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.manualmode.deployment.DeploymentScannerUnitTestCase.testStartup: <no details avaliable>

@wildfly-ci
Copy link

Linux Build 2237 outcome was SUCCESS using a merge of a60b024
Summary: Tests passed: 3377, ignored: 63 Build time: 0:36:25

@wildfly-ci
Copy link

Core - Full Integration Build 1373 outcome was FAILURE using a merge of a60b024
Summary: Tests failed: 10 (8 new), passed: 2945, ignored: 355 Build time: 0:47:42

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.messaging.mgmt.JMSQueueManagementTestCase.removeJMSQueueRemovesAllMessages: <no details avaliable>

org.jboss.as.test.integration.ejb.remote.entity.bmp.BMPRemoteEntityBeanTestCase.testGetEJBLocalHome: <no details avaliable>

org.jboss.as.test.integration.ejb.timerservice.database.DatabasePersistentCalendarTimerManagementTestCase.testResourceExistence: <no details avaliable>

org.jboss.as.test.integration.ejb.timerservice.mgmt.NonPersistentCalendarTimerManagementTestCase.testResourceExistence: <no details avaliable>

org.jboss.as.test.integration.management.deploy.runtime.StatefulEJBRemoteHomeRuntimeNameTestCase.testStatefulLocalHome: <no details avaliable>

org.jboss.as.test.integration.naming.connector.JMXConnectorTestCase.testMBeanCount: <no details avaliable>

org.jboss.as.test.integration.security.passwordmasking.PasswordMaskingInContainerTestCase.datasourceOperationsTest: <no details avaliable>

org.jboss.as.test.integration.security.vault.VaultDatasourceTestCase.testAccessThroughVaultDatasource: <no details avaliable>

org.jboss.as.test.integration.security.perimeter.CLISecurityTestCase.testConnect: <no details avaliable>

org.jboss.as.test.manualmode.web.ssl.DatabaseCertLoginModuleTestCase.testDatabaseCertLoginModule: <no details avaliable>

@bstansberry
Copy link
Contributor

retest this please

@wildfly-ci
Copy link

Linux Build 2250 is now running using a merge of a60b024

@wildfly-ci
Copy link

Windows Build 1774 is now running using a merge of a60b024

@wildfly-ci
Copy link

Core - Full Integration Build 1387 is now running using a merge of a60b024

@wildfly-ci
Copy link

Windows Build 1774 outcome was SUCCESS using a merge of a60b024
Summary: Tests passed: 3382, ignored: 63 Build time: 0:34:45

@wildfly-ci
Copy link

Linux Build 2250 outcome was SUCCESS using a merge of a60b024
Summary: Tests passed: 3382, ignored: 63 Build time: 0:35:27

@wildfly-ci
Copy link

Core - Full Integration Build 1393 outcome was FAILURE using a merge of a60b024
Summary: Tests failed: 208, passed: 2267, ignored: 338 Build time: 0:40:14

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.ejb.timerservice.serialization.TimerServiceSerializationSecondTestCase: org.jboss.as.test.integration.ejb.timerservice.persistence.TimerServicePersistenceSecondTestCase: <no details avaliable>

org.jboss.as.test.integration.ejb.timerservice.serialization.TimerServiceSerializationSecondTestCase: org.jboss.as.test.integration.ejb.timerservice.schedule.SimpleScheduleSecondTestCase: <no details avaliable>

org.jboss.as.test.integration.ejb.timerservice.serialization.TimerServiceSerializationSecondTestCase: <no details avaliable>

org.jboss.as.test.integration.security.loginmodules.LdapLoginModuleTestCase: org.jboss.as.test.integration.jca.moduledeployment.BasicFlatTestCase: <no details avaliable>

org.jboss.as.test.integration.security.loginmodules.LdapLoginModuleTestCase: org.jboss.as.test.integration.jca.moduledeployment.BasicJarTestCase: <no details avaliable>

org.jboss.as.test.integration.security.loginmodules.LdapLoginModuleTestCase: org.jboss.as.test.integration.jca.moduledeployment.InflowFlatTestCase: <no details avaliable>

org.jboss.as.test.integration.security.loginmodules.LdapLoginModuleTestCase: org.jboss.as.test.integration.jca.moduledeployment.InflowJarTestCase: <no details avaliable>

org.jboss.as.test.integration.security.loginmodules.LdapLoginModuleTestCase: org.jboss.as.test.integration.jca.moduledeployment.MultiActivationFlatTestCase: <no details avaliable>

org.jboss.as.test.integration.security.loginmodules.LdapLoginModuleTestCase: org.jboss.as.test.integration.jca.moduledeployment.MultiActivationJarTestCase: <no details avaliable>

org.jboss.as.test.integration.security.loginmodules.LdapLoginModuleTestCase: org.jboss.as.test.integration.jca.moduledeployment.MultiObjectActivationFlatTestCase: <no details avaliable>

org.jboss.as.test.integration.security.loginmodules.LdapLoginModuleTestCase: org.jboss.as.test.integration.jca.moduledeployment.MultiObjectActivationJarTestCase: <no details avaliable>


##### there are 198 more failed tests, see build details

@wildfly-ci
Copy link

Linux Build 2255 outcome was SUCCESS using a merge of a60b024
Summary: Tests passed: 3382, ignored: 63 Build time: 0:40:37

@bstansberry
Copy link
Contributor

@wildfly-ci
Copy link

Windows Build 1780 is now running using a merge of a60b024

@wildfly-ci
Copy link

Core - Full Integration Build 1396 is now running using a merge of a60b024

@wildfly-ci
Copy link

Linux Build 2257 is now running using a merge of a60b024

@bstansberry bstansberry added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Jul 23, 2015
@wildfly-ci
Copy link

Windows Build 1780 outcome was FAILURE using a merge of a60b024
Summary: Tests passed: 3343, ignored: 63; exit code 1 (new) Build time: 0:26:09

Build problems:

Process exited with code 1

@wildfly-ci
Copy link

Linux Build 2257 outcome was FAILURE using a merge of a60b024
Summary: Tests passed: 3343, ignored: 63; exit code 1 (new) Build time: 0:28:09

Build problems:

Process exited with code 1

@wildfly-ci
Copy link

Core - Full Integration Build 1396 outcome was SUCCESS using a merge of a60b024
Summary: Tests passed: 2949, ignored: 354 Build time: 0:47:31

@bstansberry bstansberry removed the ready-for-merge This PR is ready to be merged and fulfills all requirements label Jul 23, 2015
@wildfly-ci
Copy link

Windows Build 1783 is now running using a merge of c35ad01

@wildfly-ci
Copy link

Linux Build 2261 is now running using a merge of c35ad01

@wildfly-ci
Copy link

Core - Full Integration Build 1399 is now running using a merge of c35ad01

@wildfly-ci
Copy link

Windows Build 1783 outcome was FAILURE using a merge of c35ad01
Summary: Tests failed: 1 (1 new), passed: 3407, ignored: 63 Build time: 0:36:14

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.manualmode.deployment.DeploymentScannerUnitTestCase.testStartup: <no details avaliable>

@wildfly-ci
Copy link

Linux Build 2261 outcome was SUCCESS using a merge of c35ad01
Summary: Tests passed: 3408, ignored: 63 Build time: 0:36:57

@wildfly-ci
Copy link

Core - Full Integration Build 1399 outcome was FAILURE using a merge of c35ad01
Summary: Tests failed: 4 (4 new), passed: 2945, ignored: 354 Build time: 0:46:59

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.naming.connector.JMXConnectorTestCase.testMBeanCount: <no details avaliable>

org.jboss.as.test.integration.security.passwordmasking.PasswordMaskingInContainerTestCase.datasourceOperationsTest: <no details avaliable>

org.jboss.as.test.integration.security.vault.VaultDatasourceTestCase.testAccessThroughVaultDatasource: <no details avaliable>

org.jboss.as.test.manualmode.web.ssl.DatabaseCertLoginModuleTestCase.testDatabaseCertLoginModule: <no details avaliable>

@Gonthim
Copy link
Contributor Author

Gonthim commented Jul 24, 2015

retest this please

@wildfly-ci
Copy link

Windows Build 1784 is now running using a merge of c35ad01

@wildfly-ci
Copy link

Linux Build 2262 is now running using a merge of c35ad01

@wildfly-ci
Copy link

Core - Full Integration Build 1400 is now running using a merge of c35ad01

@wildfly-ci
Copy link

Windows Build 1784 outcome was SUCCESS using a merge of c35ad01
Summary: Tests passed: 3408, ignored: 63 Build time: 0:35:33

@wildfly-ci
Copy link

Linux Build 2262 outcome was SUCCESS using a merge of c35ad01
Summary: Tests passed: 3408, ignored: 63 Build time: 0:36:12

@wildfly-ci
Copy link

Core - Full Integration Build 1400 outcome was FAILURE using a merge of c35ad01
Summary: Tests failed: 6 (2 new), passed: 2943, ignored: 354 Build time: 0:45:41

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.smoke.deployment.rar.tests.earmultirar.EarPackagedMultiRarDeploymentTestCase: <no details avaliable>

org.jboss.as.test.integration.messaging.mgmt.JMSQueueManagementTestCase.removeJMSQueueRemovesAllMessages: <no details avaliable>

org.jboss.as.test.integration.naming.connector.JMXConnectorTestCase.testMBeanCount: <no details avaliable>

org.jboss.as.test.integration.security.passwordmasking.PasswordMaskingInContainerTestCase.datasourceOperationsTest: <no details avaliable>

org.jboss.as.test.integration.security.vault.VaultDatasourceTestCase.testAccessThroughVaultDatasource: <no details avaliable>

org.jboss.as.test.manualmode.web.ssl.DatabaseCertLoginModuleTestCase.testDatabaseCertLoginModule: <no details avaliable>

@Gonthim
Copy link
Contributor Author

Gonthim commented Jul 24, 2015

These seem unrelated. The 4 similar failures from the last 2 attempts also failed in 3 other recent PR builds. Can't replicate them locally with or without this commit.

bstansberry added a commit that referenced this pull request Jul 24, 2015
AESH Upgrade and associated CLI refactoring
@bstansberry bstansberry merged commit ce0ba0f into wildfly:master Jul 24, 2015
@bstansberry
Copy link
Contributor

The last 4 failures were due to some process being left around on the CI agent. The 2nd one Jeff Mesnil is about to fix (unrelated). The first is a known intermittent failure.

@bstansberry
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants