https://issues.jboss.org/browse/WFCORE-830 support multiple patch str… #906
Conversation
|
Windows Build 1744 is now running using a merge of c29a257 |
|
Linux Build 2218 is now running using a merge of c29a257 |
|
Core - Full Integration Build 1356 is now running using a merge of c29a257 |
|
Windows Build 1744 outcome was SUCCESS using a merge of c29a257 |
|
Linux Build 2218 outcome was SUCCESS using a merge of c29a257 |
|
Core - Full Integration Build 1356 outcome was SUCCESS using a merge of c29a257 |
| final ModelNode patchIdNode = PatchResourceDefinition.PATCH_ID.resolveModelAttribute(context, operation); | ||
| if(!patchIdNode.isDefined()) { | ||
| throw ControllerLogger.ROOT_LOGGER.nullNotAllowed(PatchResourceDefinition.PATCH_ID.getName()); | ||
| } |
There was a problem hiding this comment.
This doesn't seem right. If undefined is not allowed the AttributeDefinition should be configured that way and L52 will throw the exception, removing the need for this if block. But PatchResourceDefinition.PATCH_ID has allowNull set to 'true' which means the operation description will incorrectly say undefined is ok.
Perhaps the same AttributeDefinition is being used for two purposes?
There was a problem hiding this comment.
Right. I missed the description part of it.
|
Small comments aside, it looks ok. |
…eams for the same installation split installation manager and installed identity multiple identities per installation manager added patch-stream runtime resource - a child of core-service=patching, added stream name arg to the tool API and PatchingException, added optional --patch-stream arg to the CLI patch command, made patch-info OSH delegate to read-resource in case patch-id was not specified required patch-id for rollback op, optional patch-id for patch-info, removed hack for WFCORE-17, other minor fixes
aloubyansky
force-pushed
the
multiple-streams-patching
branch
from
c29a257
to
cea029d
Compare
|
Windows Build 1770 is now running using a merge of cea029d |
|
Linux Build 2246 is now running using a merge of cea029d |
|
Core - Full Integration Build 1382 is now running using a merge of cea029d |
|
Windows Build 1770 outcome was SUCCESS using a merge of cea029d |
|
Linux Build 2246 outcome was SUCCESS using a merge of cea029d |
|
Core - Full Integration Build 1382 outcome was FAILURE using a merge of cea029d Build problems:Failed tests detected Failed tests |
|
Interesting. I've seen that set of the same 4 failures on at least a couple other PR runs in the last day or so. |
|
The 4 failures were due to a problem on one of the agents; zombie process I believe. |
|
retest this please |
|
Windows Build 1772 is now running using a merge of cea029d |
|
Core - Full Integration Build 1385 is now running using a merge of cea029d |
|
Linux Build 2248 is now running using a merge of cea029d |
|
Windows Build 1772 outcome was SUCCESS using a merge of cea029d |
|
Linux Build 2248 outcome was SUCCESS using a merge of cea029d |
|
Core - Full Integration Build 1385 outcome was FAILURE using a merge of cea029d Build problems:Failed tests detected Failed tests |
bstansberry
added
the
ready-for-merge
https://issues.jboss.org/browse/WFCORE-830 support multiple patch str…
[WFCORE-5073] ConsoleMode should not return true from hasConsole if t…
…eams for the same installation
split installation manager and installed identity
multiple identities per installation manager
added patch-stream runtime resource - a child of core-service=patching, added stream name arg to the tool API and PatchingException, added optional --patch-stream arg to the CLI patch command, made patch-info OSH delegate to read-resource in case patch-id was not specified