WFCORE-805 Add capabilty information to ResourceDefinition / MRR #909
Conversation
ctomc
force-pushed
the
model-references-2
branch
2 times, most recently
from
1a7f686
to
f19abfb
Compare
|
Core - Full Integration Build 1375 is now running using a merge of f19abfb |
|
Linux Build 2239 is now running using a merge of f19abfb |
|
Windows Build 1764 is now running using a merge of f19abfb |
|
Core - Full Integration Build 1375 outcome was FAILURE using a merge of f19abfb Build problems:Process exited with code 1 |
|
Windows Build 1764 outcome was SUCCESS using a merge of f19abfb |
|
Linux Build 2239 outcome was SUCCESS using a merge of f19abfb |
| /** | ||
| * Returns capability definition for this resource. | ||
| * | ||
| * @return RuntimeCapability if any registered otherwise null |
There was a problem hiding this comment.
This will not return null but may return an empty set.
The javadoc should use plural forms; it doesn't return a single capability.
|
Other than the 2 comments, looks good. |
ctomc
force-pushed
the
model-references-2
branch
from
f19abfb
to
581ccf2
Compare
|
fixed the PR based on the comments. |
|
Core - Full Integration Build 1379 is now running using a merge of 581ccf2 |
|
Linux Build 2243 is now running using a merge of 581ccf2 |
|
Windows Build 1768 is now running using a merge of 581ccf2 |
|
Core - Full Integration Build 1379 outcome was FAILURE using a merge of 581ccf2 Build problems:Process exited with code 1 |
ctomc
force-pushed
the
model-references-2
branch
from
581ccf2
to
3675a20
Compare
| * | ||
| * @param resourceRegistration a {@link ManagementResourceRegistration} created from this definition | ||
| */ | ||
| default void registerCapabilities(final ManagementResourceRegistration resourceRegistration){ |
There was a problem hiding this comment.
just heads up, this is default method just so wildfly full code wont get angry.
|
Windows Build 1768 outcome was SUCCESS using a merge of 3675a20 |
|
Linux Build 2243 outcome was SUCCESS using a merge of 3675a20 |
|
Windows Build 1769 is now running using a merge of 3675a20 |
|
Linux Build 2244 is now running using a merge of 3675a20 |
|
Core - Full Integration Build 1380 is now running using a merge of 3675a20 |
|
Windows Build 1769 outcome was SUCCESS using a merge of 3675a20 |
|
Linux Build 2244 outcome was SUCCESS using a merge of 3675a20 |
|
Core - Full Integration Build 1383 is now running using a merge of 3675a20 |
|
Assuming the tests come out ok, this looks good. |
|
tests should be fine, the previous two full had 4 failed tests as result of hanged processes on agent. (agent has been rebooted since) |
|
Ah, ok that explains why I saw the same 4 failures on a couple other runs. Thanks. |
|
Core - Full Integration Build 1383 outcome was SUCCESS using a merge of 3675a20 |
WFCORE-805 Add capabilty information to ResourceDefinition / MRR
JBEAP-20064 Add PR template to include PR-processor hints
No description provided.