[WEJBHTTP-119] Naming: transform EJB affinities on naming invocations #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @ropalka |
|
Thanks @tadamski ! |
jbaesner
reviewed
Nov 9, 2023
| StringBuilder uriStringBuilder = new StringBuilder(); | ||
| uriStringBuilder.append(exchange.getRequestScheme()).append("://") | ||
| .append(localAddress.getHostName()).append(":").append(localAddress.getPort()) | ||
| .append("/wildfly-services"); |
There was a problem hiding this comment.
Remember /wildfly-services is the default value if nothing is explicitly configured for the http-invoker in the Undertow subsystem. So hard coding this value seems wrong.
Never mind, I see it's fixed in #163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WEJBHTTP-119
This is a hacky fix that is suppose to make sure http naming invocations are running properly. @fl4via @ropalka could you please review? Is there some more clever way to assemble local URI before sending it to the client?