Fix for WFMP-235, Introduce a start-jar goal #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm on PTO until the 2nd, but I want to think about this. I'll give it a review once I'm back if I don't get bored and review it sooner. :) |
jamezp
reviewed
Jan 4, 2024
| init(); | ||
|
|
||
| @Override | ||
| protected Path getServer() throws MojoExecutionException, MojoFailureException { |
There was a problem hiding this comment.
I think we should call this getServerHome() or getJBossHome().
| * The purpose of this goal is to start a WildFly Application Server packaged as a Bootable JAR for testing during the maven | ||
| * lifecycle. | ||
| */ | ||
| @Mojo(name = "start-bootable", requiresDependencyResolution = ResolutionScope.RUNTIME) |
There was a problem hiding this comment.
I'm just thinking a bit out loud here. Should the goal name be start-jar? Just thinking of something short to type is all, but I'm not sure I like start-jar :)
There was a problem hiding this comment.
I much prefer start-jar, start-bootable is also a bit ambiguous, all server boot... So changed to start-jar.
jfdenise
changed the title
jamezp
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/WFMP-235