[WFSSL-10] NPE with wildfly-openssl using OpenSSL 1.1.1 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstourac
reviewed
Mar 14, 2019
| @@ -573,6 +573,17 @@ WF_OPENSSL(jlong, makeSSLContext)(JNIEnv *e, jobject o, jint protocol, jint mode | |||
| if (!(protocol & SSL_PROTOCOL_TLSV1_2)) | |||
| ssl_methods.SSL_CTX_ctrl((c->ctx),SSL_CTRL_OPTIONS,(SSL_OP_NO_TLSv1_2),NULL); | |||
| } | |||
|
|
|||
| /* We need to disable TLSv1.3 if running on OpenSSL 1.1.0+ */ | |||
| #if OPENSSL_VERSION_NUMBER >= 0x10100000L | |||
There was a problem hiding this comment.
What is the exact reason to disable TLSv1.3 completely here?
There was a problem hiding this comment.
TLSv1.3 is not supported at the moment. It brings too many changes that might require some rewriting to implement.
Take a look at https://wiki.openssl.org/index.php/TLS1.3 for more details.
@fl4via, would it be safe to say that wildfly-openssl 1.0.x will be TLSv1.2 only and 1.1.x will support TLSv1.3?
There was a problem hiding this comment.
@iweiss probably, or maybe even 2.x, I'll have to define an implementation plan for this
fl4via
approved these changes
Apr 10, 2019
| @@ -573,6 +573,17 @@ WF_OPENSSL(jlong, makeSSLContext)(JNIEnv *e, jobject o, jint protocol, jint mode | |||
| if (!(protocol & SSL_PROTOCOL_TLSV1_2)) | |||
| ssl_methods.SSL_CTX_ctrl((c->ctx),SSL_CTRL_OPTIONS,(SSL_OP_NO_TLSv1_2),NULL); | |||
| } | |||
|
|
|||
| /* We need to disable TLSv1.3 if running on OpenSSL 1.1.0+ */ | |||
| #if OPENSSL_VERSION_NUMBER >= 0x10100000L | |||
There was a problem hiding this comment.
@iweiss probably, or maybe even 2.x, I'll have to define an implementation plan for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.jboss.org/browse/WFSSL-10