[#27] Support ImageStream #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmesnil
added
Basic Install (I)
|
this supersedes #130 |
jmesnil
force-pushed
the
27_imageStream_runtime
branch
2 times, most recently
from
1b28733
to
baa5123
Compare
jbliznak
reviewed
Mar 5, 2020
jmesnil
force-pushed
the
27_imageStream_runtime
branch
from
0f17753
to
7195ed7
Compare
jbliznak
reviewed
Mar 9, 2020
jmesnil
force-pushed
the
27_imageStream_runtime
branch
from
83c89b0
to
ccb7bd1
Compare
yersan
reviewed
Mar 27, 2020
|
|
||
| incremental := true | ||
|
|
||
| builderImage := w.Spec.ApplicationSource.Source2Image.BuilderImage |
There was a problem hiding this comment.
I think it could be useful if the Operator is able to check if the image does not exist yet and print a log in case. Someone could forget to import the image streams and do not understand why, if the CRD was deployed, the application is not build by the operator. The documentation states the images must be available though, so this is just a suggestion
jbliznak
suggested changes
Apr 6, 2020
jmesnil
force-pushed
the
27_imageStream_runtime
branch
from
ccb7bd1
to
217ebbc
Compare
jbliznak
reviewed
Apr 6, 2020
jmesnil
force-pushed
the
27_imageStream_runtime
branch
from
217ebbc
to
e135978
Compare
jmesnil
force-pushed
the
27_imageStream_runtime
branch
3 times, most recently
from
911048d
to
464d321
Compare
jbliznak
reviewed
Apr 7, 2020
Add Spec.ApplicationSourceSpec to build the application image from a Git repository using WildFly S2I images Make Spec.ApplicationImage optional as the definition of ApplicationSourceSpec allows an alternative. Create ImageStream and BuildConfig resources to handle S2I builds Use image.openshift.io/triggers annotation to trigger statefulset update when the image stream changes When a runtime image must be used, set GALLEON_PROVISION_DEFAULT_FAT_SERVER to true only when GALLEON_PROVISION_LAYERS is not defined. ApplicationSourceSpec's GitHubWebHookSecret and GenericWebHookSecret references secrets in the same namespace than the WildFlyServer resource. These secrets must have a key named WebHookSecretKey whose value is used to create the WebHook URL. If they are omitted from the spec, the operator will automatically generate respective secrets. Update references to WildFly 19 S2I Images Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
jmesnil
force-pushed
the
27_imageStream_runtime
branch
from
464d321
to
4c651db
Compare
|
superseded by #147 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git repository using WildFly S2I
SourceRepositorySpec allows an alternative
update when the image stream changes
This fixes #27