Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFCORE-4994 Add the ability to adjust the case of a user name using an Elytron principal transformer #315

Merged
merged 1 commit into from Dec 7, 2020

Conversation

SoniaZaldana
Copy link
Contributor

@SoniaZaldana SoniaZaldana reopened this Jun 9, 2020

== Overview

Elytron currently has six principal transformers enabling aggregating principal transofmers, chaining them, using regular expressions, etc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/transofmers/transformers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

== Test Plan

* WildFly Elytron test suite: tests for case principal transformer functionality.
* Wildfly Core test suite: testing of case principal transformer functionality when it is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to mention that Elytron subsystem parsing and transformer tests will be added. Tests should also be added in the WildFly testsuite to ensure that the correct principal is used when a case-principal-transformer has been configured.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

@msve
Copy link

msve commented Dec 1, 2020

Reviewed from QE perspective, this is good to go

@darranl darranl merged commit 6956ff0 into wildfly:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants