New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFLY-14854] Analysis document for OpenTelemetry support #407
Conversation
|
||
== Test Plan | ||
|
||
* Add tests to testsuite/integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any TCKs for OpenTelemetry specification? If not, could you elaborate more about the scope of the tests? We need to be sure that we get enough test coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know about the TCK, but we have basic tests that check that injecting io.opentelemetry.api.OpenTelemetry
and io.opentelemetry.api.trace.Tracer
work. There is also an admittedly awkwardly written test to make sure the the context propagation headers are correctly injected and handled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about some functional tests? E.g tests consisting of a deployed OTel collector (jaeger?), running server with configured opentelemetry
subsystem with client application?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the RFE focuses on application developers, there should be covered custom spans and the like.
== Overview | ||
|
||
https://opentelemetry.io[OpenTelemetry] is an ambitious specification that aims to encapsulate APIs for tracing, metrics, and logging. With OpenTracing (which WildFly already supports) having shutdown in favor of OpenTelemetry, we need to migrate our support as well. This project will only cover the tracing aspects of OpenTelemetry. Any future support for the metrics and logging parts of the OpenTelemetry spec will need to be handled by a separate effort. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This RFE focuses on developers. What are the main features for them?
00aa739
to
2ace6e6
Compare
Just added the hold label so we can merge with the backport. |
https://issues.redhat.com/browse/WFLY-14854