Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-18382] Update WFLY and EJB Maven plugin versions #10

Merged
merged 1 commit into from
Sep 5, 2023
Merged

[WFLY-18382] Update WFLY and EJB Maven plugin versions #10

merged 1 commit into from
Sep 5, 2023

Conversation

zhantemirov
Copy link

The issue: WFLY-18382

Though each QS defines own WFLY Maven plugin version in its pom.xml, it's better to have a single version among all QS (and parent as well).

If I'm not mistaken, the EJB Maven plugin should have version 3.2.1 instead of 3.2, but feel free to correct me.

@emmartins
Copy link
Contributor

emmartins commented Sep 5, 2023

I think we should actually get ridden of the plugin in the parent, those are left overs from the parent extraction that we should fix otherwise the QS is not independent as it should, i.e. every QS should have the wildfly plugin in its pom's pluginManagement section. IMHO the only resources we should keep in the parent are the ones related with the project management specifics, which the user app doesn't need (e.g. asciidoc)

@emmartins
Copy link
Contributor

I have expanded the scope of WFLY-18409 to also take care of this in the future, so for now let's merge this

@emmartins emmartins merged commit a1a8172 into wildfly:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants