CLOUD-3647 - add -Dcom.redhat.xpaas.repo.jbossorg by default to MAVEN_ARGS by default #114
Conversation
|
Looks like we have a few places looking for exact output from the tests, I'll update this. |
| export MAVEN_ARGS="${MAVEN_ARGS} -Dcom.redhat.xpaas.repo.jbossorg" |
There was a problem hiding this comment.
@luck3y , MAVEN_ARGS is not set in the image, we are relying on the cct_module default. If we are setting it here, cct_module default value will not get applied. I think that we need to append the property to MAVEN_ARGS_APPEND that the user can set and for which we don't have default values in cct_module.
There was a problem hiding this comment.
Just to add my two cents, notice MAVEN_ARGS_APPEND is by default set on the templates, so, in case of adding -Dcom.redhat.xpaas.repo.jbossorg in the scripts, it would be nice to take into account possible duplicates of the same property, bash property expansion facilities can help here. It would be harmless having the same property duplicated, but, well, just in case we want to avoid it.
|
FYI, if this is good enough for now, we can get it into CD20 |
https://issues.redhat.com/browse/CLOUD-3647
Signed-off-by: Ken Wills kwills@redhat.com