Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a property dev.resteasy.sse.closed.response.code=200 to the Jakarta REST TCK #105

Closed
jamezp opened this issue Oct 18, 2023 · 0 comments · Fixed by #107
Closed

Add a property dev.resteasy.sse.closed.response.code=200 to the Jakarta REST TCK #105

jamezp opened this issue Oct 18, 2023 · 0 comments · Fixed by #107
Assignees

Comments

@jamezp
Copy link
Member

jamezp commented Oct 18, 2023

A change in RESTEasy will require adding the -Ddev.resteasy.sse.closed.response.code=200 to the TCK.

The reason is RESTEasy was handling 204 responses incorrectly. The issue is RESTEasy returns a 204 when the SseEventSink is closed, see jakartaee/rest#1007. Other implementations seem to return 200. For this reason a configuration property was added so that the return code could be defined. The TCK itself expects a 200 which is the reason this property is being added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant